Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump HdrHistogram from 2.1.9 to 2.1.12 in /server #2135

Merged

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Feb 16, 2022

Bumps HdrHistogram from 2.1.9 to 2.1.12.

Release notes

Sourced from HdrHistogram's releases.

HdrHistogram-2.1.12

  • Fixes HdrHistogram/HdrHistogram#156
  • Adds packed histogram variants. Recorder variants can now be (optionally) constructed to use packed histogram variants.
  • Adds packed array sub-package
Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot requested a review from a team as a code owner February 16, 2022 17:02
@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Feb 16, 2022
@opensearch-ci-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Check failure 85dfe1d
Log 2436

Reports 2436

@VachaShah
Copy link
Collaborator

@dependabot recreate

@dependabot dependabot bot force-pushed the dependabot/gradle/server/org.hdrhistogram-HdrHistogram-2.1.12 branch from 85dfe1d to 30f3911 Compare February 18, 2022 00:48
@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Check failure 30f3911
Log 2546

Reports 2546

@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Check failure a360780
Log 2547

Reports 2547

@dblock
Copy link
Member

dblock commented Mar 3, 2022

❌   Gradle Check failure a360780 Log 2547

Reports 2547

Tests with failures:
 - org.opensearch.test.rest.ClientYamlTestSuiteIT.test {p0=search.aggregation/190_percentiles_hdr_metric/Filtered test}

#1817

@dblock
Copy link
Member

dblock commented Mar 3, 2022

start gradle check

@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Check failure a360780
Log 2978

Reports 2978

@dblock
Copy link
Member

dblock commented Mar 3, 2022

❌   Gradle Check failure a360780 Log 2978

Reports 2978

> Task :server:thirdPartyAudit FAILED

Tests with failures:
 - org.opensearch.test.rest.ClientYamlTestSuiteIT.test {p0=search.aggregation/190_percentiles_hdr_metric/Filtered test}

@VachaShah
Copy link
Collaborator

The precommit on this PR needs to be fixed:

Unnecessary exclusions, following classes are not missing:
   * javax.xml.bind.DatatypeConverter

@dblock
Copy link
Member

dblock commented Mar 21, 2022

@dependabot recreate

@dependabot dependabot bot force-pushed the dependabot/gradle/server/org.hdrhistogram-HdrHistogram-2.1.12 branch from a360780 to 435de34 Compare March 21, 2022 19:03
@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Check failure 435de34
Log 3599

Reports 3599

@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Check failure 116e428
Log 3605

Reports 3605

@dblock
Copy link
Member

dblock commented Mar 21, 2022

> Task :server:thirdPartyAudit FAILED
Unnecessary exclusions, following classes are not missing:
   * javax.xml.bind.DatatypeConverter

@saratvemulapalli Do we usually fix these by hand?

@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Check failure 57483a2
Log 3642

Reports 3642

@VachaShah
Copy link
Collaborator

REPRODUCE WITH: ./gradlew ':server:internalClusterTest' --tests "org.opensearch.blocks.SimpleBlocksIT.testAddBlockWhileDeletingIndices" -Dtests.seed=AB18045F9557378F -Dtests.security.manager=true -Dtests.jvm.argline="-XX:TieredStopAtLevel=1 -XX:ReservedCodeCacheSize=64m" -Dtests.locale=el -Dtests.timezone=America/Creston -Druntime.java=17

org.opensearch.blocks.SimpleBlocksIT > testAddBlockWhileDeletingIndices FAILED
    com.carrotsearch.randomizedtesting.UncaughtExceptionError: Captured an uncaught exception in thread: Thread[id=317, name=Thread-5, state=RUNNABLE, group=TGRP-SimpleBlocksIT]
REPRODUCE WITH: ./gradlew ':rest-api-spec:yamlRestTest' --tests "org.opensearch.test.rest.ClientYamlTestSuiteIT" -Dtests.method="test {p0=search.aggregation/190_percentiles_hdr_metric/Filtered test}" -Dtests.seed=AB18045F9557378F -Dtests.security.manager=true -Dtests.jvm.argline="-XX:TieredStopAtLevel=1 -XX:ReservedCodeCacheSize=64m" -Dtests.locale=no-NO -Dtests.timezone=Pacific/Fakaofo -Druntime.java=17

org.opensearch.test.rest.ClientYamlTestSuiteIT > test {p0=search.aggregation/190_percentiles_hdr_metric/Filtered test} FAILED
    java.lang.AssertionError: Failure at [search.aggregation/190_percentiles_hdr_metric:190]: aggregations.percentiles_int.values.75\.0 didn't match expected value:
    aggregations.percentiles_int.values.75\.0: expected Double [101.03125] but was Double [151.09375]
REPRODUCE WITH: ./gradlew ':qa:smoke-test-multinode:integTest' --tests "org.opensearch.smoketest.SmokeTestMultiNodeClientYamlTestSuiteIT" -Dtests.method="test {yaml=search.aggregation/190_percentiles_hdr_metric/Filtered test}" -Dtests.seed=AB18045F9557378F -Dtests.security.manager=true -Dtests.jvm.argline="-XX:TieredStopAtLevel=1 -XX:ReservedCodeCacheSize=64m" -Dtests.locale=es-HN -Dtests.timezone=America/Knox_IN -Druntime.java=17

org.opensearch.smoketest.SmokeTestMultiNodeClientYamlTestSuiteIT > test {yaml=search.aggregation/190_percentiles_hdr_metric/Filtered test} FAILED
    java.lang.AssertionError: Failure at [search.aggregation/190_percentiles_hdr_metric:190]: aggregations.percentiles_int.values.75\.0 didn't match expected value:
    aggregations.percentiles_int.values.75\.0: expected Double [101.03125] but was Double [151.09375]
REPRODUCE WITH: ./gradlew ':qa:mixed-cluster:v1.3.1#mixedClusterTest' --tests "org.opensearch.backwards.MixedClusterClientYamlTestSuiteIT" -Dtests.method="test {p0=search.aggregation/190_percentiles_hdr_metric/Filtered test}" -Dtests.seed=AB18045F9557378F -Dtests.security.manager=true -Dtests.jvm.argline="-XX:TieredStopAtLevel=1 -XX:ReservedCodeCacheSize=64m" -Dtests.locale=uk-UA -Dtests.timezone=US/Samoa -Druntime.java=17

org.opensearch.backwards.MixedClusterClientYamlTestSuiteIT > test {p0=search.aggregation/190_percentiles_hdr_metric/Filtered test} FAILED
    java.lang.AssertionError: Failure at [search.aggregation/190_percentiles_hdr_metric:190]: aggregations.percentiles_int.values.75\.0 didn't match expected value:
    aggregations.percentiles_int.values.75\.0: expected Double [101.03125] but was Double [151.09375]
        at __r

@saratvemulapalli
Copy link
Member

start gradle check

@VachaShah
Copy link
Collaborator

REPRODUCE WITH: ./gradlew ':server:internalClusterTest' --tests "org.opensearch.blocks.SimpleBlocksIT.testAddBlockWhileDeletingIndices" -Dtests.seed=AB18045F9557378F -Dtests.security.manager=true -Dtests.jvm.argline="-XX:TieredStopAtLevel=1 -XX:ReservedCodeCacheSize=64m" -Dtests.locale=el -Dtests.timezone=America/Creston -Druntime.java=17

org.opensearch.blocks.SimpleBlocksIT > testAddBlockWhileDeletingIndices FAILED
    com.carrotsearch.randomizedtesting.UncaughtExceptionError: Captured an uncaught exception in thread: Thread[id=317, name=Thread-5, state=RUNNABLE, group=TGRP-SimpleBlocksIT]
REPRODUCE WITH: ./gradlew ':rest-api-spec:yamlRestTest' --tests "org.opensearch.test.rest.ClientYamlTestSuiteIT" -Dtests.method="test {p0=search.aggregation/190_percentiles_hdr_metric/Filtered test}" -Dtests.seed=AB18045F9557378F -Dtests.security.manager=true -Dtests.jvm.argline="-XX:TieredStopAtLevel=1 -XX:ReservedCodeCacheSize=64m" -Dtests.locale=no-NO -Dtests.timezone=Pacific/Fakaofo -Druntime.java=17

org.opensearch.test.rest.ClientYamlTestSuiteIT > test {p0=search.aggregation/190_percentiles_hdr_metric/Filtered test} FAILED
    java.lang.AssertionError: Failure at [search.aggregation/190_percentiles_hdr_metric:190]: aggregations.percentiles_int.values.75\.0 didn't match expected value:
    aggregations.percentiles_int.values.75\.0: expected Double [101.03125] but was Double [151.09375]
REPRODUCE WITH: ./gradlew ':qa:smoke-test-multinode:integTest' --tests "org.opensearch.smoketest.SmokeTestMultiNodeClientYamlTestSuiteIT" -Dtests.method="test {yaml=search.aggregation/190_percentiles_hdr_metric/Filtered test}" -Dtests.seed=AB18045F9557378F -Dtests.security.manager=true -Dtests.jvm.argline="-XX:TieredStopAtLevel=1 -XX:ReservedCodeCacheSize=64m" -Dtests.locale=es-HN -Dtests.timezone=America/Knox_IN -Druntime.java=17

org.opensearch.smoketest.SmokeTestMultiNodeClientYamlTestSuiteIT > test {yaml=search.aggregation/190_percentiles_hdr_metric/Filtered test} FAILED
    java.lang.AssertionError: Failure at [search.aggregation/190_percentiles_hdr_metric:190]: aggregations.percentiles_int.values.75\.0 didn't match expected value:
    aggregations.percentiles_int.values.75\.0: expected Double [101.03125] but was Double [151.09375]
REPRODUCE WITH: ./gradlew ':qa:mixed-cluster:v1.3.1#mixedClusterTest' --tests "org.opensearch.backwards.MixedClusterClientYamlTestSuiteIT" -Dtests.method="test {p0=search.aggregation/190_percentiles_hdr_metric/Filtered test}" -Dtests.seed=AB18045F9557378F -Dtests.security.manager=true -Dtests.jvm.argline="-XX:TieredStopAtLevel=1 -XX:ReservedCodeCacheSize=64m" -Dtests.locale=uk-UA -Dtests.timezone=US/Samoa -Druntime.java=17

org.opensearch.backwards.MixedClusterClientYamlTestSuiteIT > test {p0=search.aggregation/190_percentiles_hdr_metric/Filtered test} FAILED
    java.lang.AssertionError: Failure at [search.aggregation/190_percentiles_hdr_metric:190]: aggregations.percentiles_int.values.75\.0 didn't match expected value:
    aggregations.percentiles_int.values.75\.0: expected Double [101.03125] but was Double [151.09375]
        at __r

The first test failure looks from a flaky test but the other 3 look to be genuine since they are related to Hdr percentiles. I am not that aware of these tests and Hdr though. @saratvemulapalli Do you happen to know about it?

@saratvemulapalli
Copy link
Member

saratvemulapalli commented Mar 22, 2022

Thats a good point. Looks like genuine failures. I do not know how it works but we can learn.
@Rishikesh1159 do you mind taking a look at this?

expected Double [101.03125] but was Double [151.09375]

@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Check failure 57483a2
Log 3675

Reports 3675

@Rishikesh1159
Copy link
Member

Thats a good point. Looks like genuine failures. I do not know how it works but we can learn. @Rishikesh1159 do you mind taking a look at this?

expected Double [101.03125] but was Double [151.09375]

Sure.

@Rishikesh1159
Copy link
Member

start gradle check

@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Check failure 57483a2
Log 4132

Reports 4132

@dblock
Copy link
Member

dblock commented Apr 5, 2022

This looks like a legit test failure.

@Rishikesh1159
Copy link
Member

Yes this is not flaky test failure. From HdrHistogram version 2.1.10 and up there are some changes causing this.This test failure which was previously failing is not failing anymore:

REPRODUCE WITH: ./gradlew ':qa:mixed-cluster:v1.3.1#mixedClusterTest' --tests "org.opensearch.backwards.MixedClusterClientYamlTestSuiteIT" -Dtests.method="test {p0=search.aggregation/190_percentiles_hdr_metric/Filtered test}" -Dtests.seed=AB18045F9557378F -Dtests.security.manager=true -Dtests.jvm.argline="-XX:TieredStopAtLevel=1 -XX:ReservedCodeCacheSize=64m" -Dtests.locale=uk-UA -Dtests.timezone=US/Samoa -Druntime.java=17

org.opensearch.backwards.MixedClusterClientYamlTestSuiteIT > test {p0=search.aggregation/190_percentiles_hdr_metric/Filtered test} FAILED
    java.lang.AssertionError: Failure at [search.aggregation/190_percentiles_hdr_metric:190]: aggregations.percentiles_int.values.75\.0 didn't match expected value:
    aggregations.percentiles_int.values.75\.0: expected Double [101.03125] but was Double [151.09375]
        at __r

There are still two tests failing, I will update here if I find any fix for these.

@kartg
Copy link
Member

kartg commented Apr 27, 2022

@dependabot recreate

@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Check failure 14d7c92
Log 4842

Reports 4842

@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Check failure 9c7af33
Log 4843

Reports 4843

@kartg
Copy link
Member

kartg commented Apr 29, 2022

start gradle check

@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Check failure 9c7af33
Log 4871

Reports 4871

@kartg
Copy link
Member

kartg commented Apr 29, 2022

start gradle check

@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Check failure 9c7af33
Log 4875

Reports 4875

@kartg
Copy link
Member

kartg commented Apr 30, 2022

One unnecessary exclusion:

> Task :server:thirdPartyAudit FAILED
Unnecessary exclusions, following classes are not missing:
   * javax.xml.bind.DatatypeConverter

The rest of the failures are hdr related:

> Task :qa:smoke-test-multinode:integTest

REPRODUCE WITH: ./gradlew ':qa:smoke-test-multinode:integTest' --tests "org.opensearch.smoketest.SmokeTestMultiNodeClientYamlTestSuiteIT" -Dtests.method="test {yaml=search.aggregation/190_percentiles_hdr_metric/Filtered test}" -Dtests.seed=9FE21098A3D489E8 -Dtests.security.manager=true -Dtests.jvm.argline="-XX:TieredStopAtLevel=1 -XX:ReservedCodeCacheSize=64m" -Dtests.locale=ar-YE -Dtests.timezone=America/Caracas -Druntime.java=17

org.opensearch.smoketest.SmokeTestMultiNodeClientYamlTestSuiteIT > test {yaml=search.aggregation/190_percentiles_hdr_metric/Filtered test} FAILED
    java.lang.AssertionError: Failure at [search.aggregation/190_percentiles_hdr_metric:190]: aggregations.percentiles_int.values.75\.0 didn't match expected value:
    aggregations.percentiles_int.values.75\.0: expected Double [101.03125] but was Double [151.09375]

....

> Task :rest-api-spec:yamlRestTest

REPRODUCE WITH: ./gradlew ':rest-api-spec:yamlRestTest' --tests "org.opensearch.test.rest.ClientYamlTestSuiteIT" -Dtests.method="test {p0=search.aggregation/190_percentiles_hdr_metric/Filtered test}" -Dtests.seed=9FE21098A3D489E8 -Dtests.security.manager=true -Dtests.jvm.argline="-XX:TieredStopAtLevel=1 -XX:ReservedCodeCacheSize=64m" -Dtests.locale=pt-PT -Dtests.timezone=CST -Druntime.java=17

org.opensearch.test.rest.ClientYamlTestSuiteIT > test {p0=search.aggregation/190_percentiles_hdr_metric/Filtered test} FAILED
    java.lang.AssertionError: Failure at [search.aggregation/190_percentiles_hdr_metric:190]: aggregations.percentiles_int.values.75\.0 didn't match expected value:
    aggregations.percentiles_int.values.75\.0: expected Double [101.03125] but was Double [151.09375]

....

> Task :qa:mixed-cluster:v2.1.0#mixedClusterTest

REPRODUCE WITH: ./gradlew ':qa:mixed-cluster:v2.1.0#mixedClusterTest' --tests "org.opensearch.backwards.MixedClusterClientYamlTestSuiteIT" -Dtests.method="test {p0=search.aggregation/190_percentiles_hdr_metric/Filtered test}" -Dtests.seed=9FE21098A3D489E8 -Dtests.security.manager=true -Dtests.jvm.argline="-XX:TieredStopAtLevel=1 -XX:ReservedCodeCacheSize=64m" -Dtests.locale=vi -Dtests.timezone=Poland -Druntime.java=17

org.opensearch.backwards.MixedClusterClientYamlTestSuiteIT > test {p0=search.aggregation/190_percentiles_hdr_metric/Filtered test} FAILED
    java.lang.AssertionError: Failure at [search.aggregation/190_percentiles_hdr_metric:190]: aggregations.percentiles_int.values.75\.0 didn't match expected value:
    aggregations.percentiles_int.values.75\.0: expected Double [101.03125] but was Double [151.09375]

@kartg
Copy link
Member

kartg commented May 2, 2022

Some more digging - even though there are 18 occurrences of REPRODUCE WITH, there are only 3 unique commands:

./gradlew ':qa:mixed-cluster:v2.1.0#mixedClusterTest' --tests "org.opensearch.backwards.MixedClusterClientYamlTestSuiteIT" -Dtests.method="test {p0=search.aggregation/190_percentiles_hdr_metric/Filtered test}" -Dtests.seed=9FE21098A3D489E8 -Dtests.security.manager=true -Dtests.jvm.argline="-XX:TieredStopAtLevel=1 -XX:ReservedCodeCacheSize=64m" -Dtests.locale=vi -Dtests.timezone=Poland -Druntime.java=17

./gradlew ':qa:smoke-test-multinode:integTest' --tests "org.opensearch.smoketest.SmokeTestMultiNodeClientYamlTestSuiteIT" -Dtests.method="test {yaml=search.aggregation/190_percentiles_hdr_metric/Filtered test}" -Dtests.seed=9FE21098A3D489E8 -Dtests.security.manager=true -Dtests.jvm.argline="-XX:TieredStopAtLevel=1 -XX:ReservedCodeCacheSize=64m" -Dtests.locale=ar-YE -Dtests.timezone=America/Caracas -Druntime.java=17

./gradlew ':rest-api-spec:yamlRestTest' --tests "org.opensearch.test.rest.ClientYamlTestSuiteIT" -Dtests.method="test {p0=search.aggregation/190_percentiles_hdr_metric/Filtered test}" -Dtests.seed=9FE21098A3D489E8 -Dtests.security.manager=true -Dtests.jvm.argline="-XX:TieredStopAtLevel=1 -XX:ReservedCodeCacheSize=64m" -Dtests.locale=pt-PT -Dtests.timezone=CST -Druntime.java=17

All of these failures are with the Filtered test test case - the rest of the cases ("Basic test", "only aggs test", etc.) pass.

@kartg
Copy link
Member

kartg commented May 3, 2022

Looks like this change was introduced in org.hdrhistogram:HdrHistogram version 2.1.10. Here's the commit indicating a change in behavior of getValueAtPercentile - HdrHistogram/HdrHistogram@5c7226c

@kartg
Copy link
Member

kartg commented May 3, 2022

Wrote up a test class to illustrate the change in behavior:

import java.util.Arrays;
import org.HdrHistogram.DoubleHistogram;

public class DoubleHistogramTest {

	private static final int[] VALUES = {51, 101, 151};
	private static final double PERCENTILE = 75.0;

	public static void main(String args[]) {
		final DoubleHistogram state = new DoubleHistogram(5);
		Arrays.stream(VALUES).forEach(state::recordValue);
		double val = state.getValueAtPercentile(PERCENTILE);
		System.out.println("Output - " + val);
	}
}

Test runs:

javac -cp './HdrHistogram-2.1.9.jar:.' DoubleHistogramTest.java && java -cp './HdrHistogram-2.1.9.jar:.' DoubleHistogramTest
Picked up JAVA_TOOL_OPTIONS: -Dlog4j2.formatMsgNoLookups=true
Picked up JAVA_TOOL_OPTIONS: -Dlog4j2.formatMsgNoLookups=true
Output - 101.000244140625

javac -cp './HdrHistogram-2.1.10.jar:.' DoubleHistogramTest.java && java -cp './HdrHistogram-2.1.10.jar:.' DoubleHistogramTest
Picked up JAVA_TOOL_OPTIONS: -Dlog4j2.formatMsgNoLookups=true
Picked up JAVA_TOOL_OPTIONS: -Dlog4j2.formatMsgNoLookups=true
Output - 151.000732421875

@kartg
Copy link
Member

kartg commented May 3, 2022

Side note: resolving the unnecessary exclusion of javax.xml.bind.DatatypeConverter is easy - these lines need to be removed

@andrross
Copy link
Member

andrross commented May 4, 2022

I pushed a commit the simply updates our tests to expect the new behavior of HdrHistogram. This seems like the right thing to do to me, but I'll want confirmation from some other folks as well.

@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Check failure e9b99bd
Log 4977

Reports 4977

@andrross
Copy link
Member

andrross commented May 4, 2022

My change doesn't work because the backward compatibility tests run this test against a mixed cluster. In order to avoid problems there I think we'll have to change the test to work against both versions.

There was a [change in behavior in HdrHistogram][1] that causes the
tests to fail with the new version. The fix here is to add another value
in the test data set for the failing test, which has the result of
making both versions of HdrHistogram agree on the percentile values.

[1]: HdrHistogram/HdrHistogram@5c7226c

Signed-off-by: Andrew Ross <[email protected]>
@andrross andrross force-pushed the dependabot/gradle/server/org.hdrhistogram-HdrHistogram-2.1.12 branch from e9b99bd to 1948e5b Compare May 4, 2022 21:03
@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Check failure 1948e5b
Log 5008

Reports 5008

@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Check failure 4d4f81a
Log 5014

Reports 5014

@andrross
Copy link
Member

andrross commented May 4, 2022

Latest failures are:

- :distribution:docker:composeUp
- ./gradlew ':server:internalClusterTest' --tests "org.opensearch.indices.settings.UpdateNumberOfReplicasIT.testSimpleUpdateNumberOfReplicas" -Dtests.seed=AAE08EAC64F10727 -Dtests.security.manager=true -Dtests.jvm.argline="-XX:TieredStopAtLevel=1 -XX:ReservedCodeCacheSize=64m" -Dtests.locale=el-GR -Dtests.timezone=America/Santa_Isabel -Druntime.java=17
- ./gradlew ':server:internalClusterTest' --tests "org.opensearch.recovery.RecoveryWhileUnderLoadIT.testRecoverWhileRelocating" -Dtests.seed=AAE08EAC64F10727 -Dtests.security.manager=true -Dtests.jvm.argline="-XX:TieredStopAtLevel=1 -XX:ReservedCodeCacheSize=64m" -Dtests.locale=sr-Latn-ME -Dtests.timezone=America/Yellowknife -Druntime.java=17

None are reproducible.

@andrross
Copy link
Member

andrross commented May 4, 2022

start gradle check

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Check success 4d4f81a
Log 5020

Reports 5020

@andrross andrross merged commit bce7f49 into main May 5, 2022
@dependabot dependabot bot deleted the dependabot/gradle/server/org.hdrhistogram-HdrHistogram-2.1.12 branch May 5, 2022 16:30
@andrross andrross added the backport 2.x Backport to 2.x branch label May 5, 2022
opensearch-trigger-bot bot pushed a commit that referenced this pull request May 5, 2022
* Bump HdrHistogram from 2.1.9 to 2.1.12 in /server

Bumps [HdrHistogram](https://github.com/HdrHistogram/HdrHistogram) from 2.1.9 to 2.1.12.
- [Release notes](https://github.com/HdrHistogram/HdrHistogram/releases)
- [Commits](HdrHistogram/HdrHistogram@HdrHistogram-2.1.9...HdrHistogram-2.1.12)

---
updated-dependencies:
- dependency-name: org.hdrhistogram:HdrHistogram
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

* Updating SHAs

Signed-off-by: dependabot[bot] <[email protected]>

* Update test to match new behavior of HdrHistogram

There was a [change in behavior in HdrHistogram][1] that causes the
tests to fail with the new version. The fix here is to add another value
in the test data set for the failing test, which has the result of
making both versions of HdrHistogram agree on the percentile values.

[1]: HdrHistogram/HdrHistogram@5c7226c

Signed-off-by: Andrew Ross <[email protected]>

* Remove unnecessary exclusion on third party audit

Signed-off-by: Andrew Ross <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com>
Co-authored-by: Andrew Ross <[email protected]>
(cherry picked from commit bce7f49)
dblock pushed a commit that referenced this pull request May 6, 2022
* Bump HdrHistogram from 2.1.9 to 2.1.12 in /server

Bumps [HdrHistogram](https://github.com/HdrHistogram/HdrHistogram) from 2.1.9 to 2.1.12.
- [Release notes](https://github.com/HdrHistogram/HdrHistogram/releases)
- [Commits](HdrHistogram/HdrHistogram@HdrHistogram-2.1.9...HdrHistogram-2.1.12)

---
updated-dependencies:
- dependency-name: org.hdrhistogram:HdrHistogram
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

* Updating SHAs

Signed-off-by: dependabot[bot] <[email protected]>

* Update test to match new behavior of HdrHistogram

There was a [change in behavior in HdrHistogram][1] that causes the
tests to fail with the new version. The fix here is to add another value
in the test data set for the failing test, which has the result of
making both versions of HdrHistogram agree on the percentile values.

[1]: HdrHistogram/HdrHistogram@5c7226c

Signed-off-by: Andrew Ross <[email protected]>

* Remove unnecessary exclusion on third party audit

Signed-off-by: Andrew Ross <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com>
Co-authored-by: Andrew Ross <[email protected]>
(cherry picked from commit bce7f49)

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants