Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Snapshot v2] Run queued operations post v2 operations completion #16179

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

gbbafna
Copy link
Collaborator

@gbbafna gbbafna commented Oct 3, 2024

Description

For snapshot-v2, we don't allow concurrent snapshots . But meanwhile non-v2 snapshot operations (clone / delete) can get queued . This is triggering the queued v1 operations.

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link
Contributor

github-actions bot commented Oct 3, 2024

❕ Gradle check result for ebdf154: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

Copy link

codecov bot commented Oct 3, 2024

Codecov Report

Attention: Patch coverage is 55.55556% with 4 lines in your changes missing coverage. Please review.

Project coverage is 71.91%. Comparing base (6020c58) to head (ebdf154).

Files with missing lines Patch % Lines
...ava/org/opensearch/snapshots/SnapshotsService.java 55.55% 4 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main   #16179      +/-   ##
============================================
+ Coverage     71.88%   71.91%   +0.02%     
- Complexity    64496    64520      +24     
============================================
  Files          5291     5291              
  Lines        301668   301670       +2     
  Branches      43576    43576              
============================================
+ Hits         216863   216950      +87     
+ Misses        67031    66914     -117     
- Partials      17774    17806      +32     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant