[Star tree] Support for keyword changes as part of star tree mapper #16103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bharathwaj G <[email protected]>
Signed-off-by: Bharathwaj G <[email protected]>
…timestamp-support
Signed-off-by: Bharathwaj G <[email protected]>
…timestamp-support
…timestamp-support
…timestamp-support
Signed-off-by: Bharathwaj G <[email protected]>
…timestamp-support
…timestamp-support
Signed-off-by: Bharathwaj G <[email protected]>
…timestamp-support
|
❌ Gradle check result for 249fa53: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
This was referenced Sep 27, 2024
Signed-off-by: Bharathwaj G <[email protected]>
bharath-techie
force-pushed
the
keyword-mapper
branch
from
249fa53
to
49dd2f5
Compare
|
❌ Gradle check result for 49dd2f5: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
| if (hasDocValues) { | ||
| return "numeric"; | ||
| } else if (isKeyword) { | ||
| return "keyword"; | ||
| return "ip"; |
There was a problem hiding this comment.
why are we returning "ip" in the above two ifs?
| return DocValues.emptySortedNumeric(); | ||
| } | ||
| }); | ||
| if(isSortedSetField(compositeField)) { |
There was a problem hiding this comment.
should we have a switch? for when we support more field types.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR supports keyword fields as part of the star tree mapping.
This is built on top of date mapping PR.
Related Issues
Resolves #[Issue number to be closed when this PR is merged]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.