[Backport 2.17] Add support to upload snapshot shard blobs with hashed prefix #15649
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…arch-project#15426) * Add snapshot shard blobs with hashed prefix Signed-off-by: Ashish Singh <[email protected]> * Add UTs Signed-off-by: Ashish Singh <[email protected]> * Address comments and add UTs Signed-off-by: Ashish Singh <[email protected]> * Change default snapshot shard path type to hashed_prefix for testing Signed-off-by: Ashish Singh <[email protected]> * Fix failing tests Signed-off-by: Ashish Singh <[email protected]> * Introduce single method for all create/put repository calls Signed-off-by: Ashish Singh <[email protected]> * Move the index shard path upload to sync upload Signed-off-by: Ashish Singh <[email protected]> * Fix spotless errors Signed-off-by: Ashish Singh <[email protected]> * Do minor code refactor Signed-off-by: Ashish Singh <[email protected]> * Fix tests Signed-off-by: Ashish Singh <[email protected]> * More tests to use common methods for repo creation Signed-off-by: Ashish Singh <[email protected]> * Address comments and fix multiple failing tests Signed-off-by: Ashish Singh <[email protected]> --------- Signed-off-by: Ashish Singh <[email protected]>
…t#15426 (opensearch-project#15559) Signed-off-by: Ashish Singh <[email protected]>
…oject#15560) Signed-off-by: Ashish Singh <[email protected]>
Signed-off-by: Ashish Singh <[email protected]>
ashking94
requested review from
anasalkouz,
andrross,
Bukhtawar,
CEHENKLE,
dblock,
dbwiddis,
gbbafna,
jed326,
kotwanikunal,
mch2,
msfroh,
nknize,
owaiskazi19,
reta,
Rishikesh1159,
sachinpkale,
saratvemulapalli,
shwetathareja,
sohami,
VachaShah,
jainankitk and
linuxpi
as code owners
ashking94
changed the title
Signed-off-by: Ashish Singh <[email protected]>
|
❌ Gradle check result for f67be03: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
❌ Gradle check result for 00da4f3: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 2.17 #15649 +/- ##
============================================
+ Coverage 71.62% 71.67% +0.04%
- Complexity 63996 64107 +111
============================================
Files 5248 5249 +1
Lines 299513 299749 +236
Branches 43609 43638 +29
============================================
+ Hits 214524 214840 +316
+ Misses 67022 66921 -101
- Partials 17967 17988 +21 ☔ View full report in Codecov by Sentry. |
gbbafna
approved these changes
Sep 4, 2024
This was referenced Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport c308b98 from #15426.
Backport 4c98c7e from #15559.
Backport 758c2aa from #15560.