-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Star tree] Adding date field rounding support in star tree #15249
base: main
Are you sure you want to change the base?
[Star tree] Adding date field rounding support in star tree #15249
Conversation
5fdce71
to
23e600a
Compare
❌ Gradle check result for 5fdce71: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❌ Gradle check result for 23e600a: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
23e600a
to
6fbaf1b
Compare
❌ Gradle check result for 6fbaf1b: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Bharathwaj G <[email protected]>
6fbaf1b
to
3f82b5a
Compare
150e0b8
to
4387345
Compare
❕ Gradle check result for 4387345: UNSTABLE Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #15249 +/- ##
============================================
- Coverage 71.87% 71.86% -0.01%
- Complexity 64528 64542 +14
============================================
Files 5296 5298 +2
Lines 301744 301867 +123
Branches 43585 43603 +18
============================================
+ Hits 216864 216926 +62
- Misses 67014 67164 +150
+ Partials 17866 17777 -89 ☔ View full report in Codecov by Sentry. |
…timestamp-support
Signed-off-by: Bharathwaj G <[email protected]>
…timestamp-support
❌ Gradle check result for eb43e37: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
...a/org/opensearch/index/compositeindex/datacube/startree/utils/date/ExtendedDateTimeUnit.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/opensearch/index/compositeindex/datacube/Dimension.java
Outdated
Show resolved
Hide resolved
.../java/org/opensearch/index/compositeindex/datacube/startree/builder/BaseStarTreeBuilder.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/opensearch/index/compositeindex/datacube/Dimension.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/opensearch/index/compositeindex/datacube/ReadDimension.java
Show resolved
Hide resolved
server/src/main/java/org/opensearch/index/compositeindex/datacube/DateDimension.java
Outdated
Show resolved
Hide resolved
...a/org/opensearch/index/compositeindex/datacube/startree/utils/date/ExtendedDateTimeUnit.java
Outdated
Show resolved
Hide resolved
…timestamp-support
❌ Gradle check result for 93760bc: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Bharathwaj G <[email protected]>
93760bc
to
d34a36f
Compare
❕ Gradle check result for d34a36f: UNSTABLE Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
...a/org/opensearch/index/compositeindex/datacube/startree/utils/date/DataCubeDateTimeUnit.java
Outdated
Show resolved
Hide resolved
...a/org/opensearch/index/compositeindex/datacube/startree/utils/date/DataCubeDateTimeUnit.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/opensearch/index/compositeindex/datacube/DateDimension.java
Show resolved
Hide resolved
server/src/main/java/org/opensearch/index/compositeindex/datacube/DateDimension.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/opensearch/index/compositeindex/datacube/startree/StarTreeField.java
Outdated
Show resolved
Hide resolved
.../java/org/opensearch/index/compositeindex/datacube/startree/builder/BaseStarTreeBuilder.java
Show resolved
Hide resolved
...va/org/opensearch/index/compositeindex/datacube/startree/builder/OffHeapStarTreeBuilder.java
Show resolved
Hide resolved
...ensearch/index/compositeindex/datacube/startree/fileformats/meta/StarTreeMetadataWriter.java
Show resolved
Hide resolved
...a/org/opensearch/index/compositeindex/datacube/startree/utils/date/DateTimeUnitRounding.java
Show resolved
Hide resolved
Signed-off-by: Bharathwaj G <[email protected]>
❌ Gradle check result for 309f539: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
309f539
to
d9e7852
Compare
❌ Gradle check result for d9e7852: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
…timestamp-support
d9e7852
to
8215865
Compare
Description
User can give up to three calendar_intervals as part of Date_Dimension as part of star tree mapping. We will round off the value in date field as per the interval. Both nano and millis resolution are rounded off.
Anything greater than or equal to
Hour
interval will only work for UTC timezone and 00:00 offset.We will add support for timezones and offsets later. #15266
User can specify date dimension as above with defaults being 'minute' and 'half an hour'. The date field ( both milliseconds and nanoseconds resolution ) will get rounded off to the associated calendar interval.
Apart from date histogram calendar intervals,
User can provide
quarter of hour
/half an hour
as part of mapping .This is done to handle all timezones.
15m interval will handle all timezones and 30m interval will handle 99% of timezones bar the ones which has :45 minute part as part of timezone.
Related Issues
Resolves #15265
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.