Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix (some) AzureBlobContainerRetriesTests flaky tests #15184

Merged
merged 1 commit into from
Aug 9, 2024

Conversation

reta
Copy link
Collaborator

@reta reta commented Aug 9, 2024

Description

Seems like the timeout of 2 seconds was quite aggressive, bumping it to 5 seconds.

Related Issues

Closes #14318

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link
Contributor

github-actions bot commented Aug 9, 2024

❕ Gradle check result for f2c1e26: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

Copy link

codecov bot commented Aug 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.84%. Comparing base (875b603) to head (f2c1e26).

Additional details and impacted files
@@             Coverage Diff              @@
##               main   #15184      +/-   ##
============================================
- Coverage     71.91%   71.84%   -0.07%     
+ Complexity    63016    63003      -13     
============================================
  Files          5185     5185              
  Lines        295183   295183              
  Branches      42663    42663              
============================================
- Hits         212279   212077     -202     
- Misses        65461    65643     +182     
- Partials      17443    17463      +20     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mch2 mch2 merged commit 3b358e3 into opensearch-project:main Aug 9, 2024
58 checks passed
@reta reta changed the title Fix (some_ AzureBlobContainerRetriesTests flaky tests Fix (some) AzureBlobContainerRetriesTests flaky tests Aug 9, 2024
@reta reta added the backport 2.x Backport to 2.x branch label Aug 9, 2024
opensearch-trigger-bot bot pushed a commit that referenced this pull request Aug 9, 2024
(cherry picked from commit 3b358e3)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
reta pushed a commit that referenced this pull request Aug 9, 2024
(cherry picked from commit 3b358e3)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
harshavamsi pushed a commit to harshavamsi/OpenSearch that referenced this pull request Aug 20, 2024
wdongyu pushed a commit to wdongyu/OpenSearch that referenced this pull request Aug 22, 2024
akolarkunnu pushed a commit to akolarkunnu/OpenSearch that referenced this pull request Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autocut backport 2.x Backport to 2.x branch flaky-test Random test failure that succeeds on second run skip-changelog Storage:Snapshots >test-failure Test failure from CI, local build, etc.
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

[AUTOCUT] Gradle Check Flaky Test Report for AzureBlobContainerRetriesTests
2 participants