Fix RemoteCloneIndex flaky test by using sync FS repo #15037
Conversation
github-actions
bot
added
>test-failure
gbbafna
requested review from
anasalkouz,
andrross,
ashking94,
Bukhtawar,
CEHENKLE,
dblock,
dbwiddis,
kotwanikunal,
mch2,
msfroh,
nknize,
owaiskazi19,
reta,
Rishikesh1159,
sachinpkale,
saratvemulapalli,
shwetathareja,
sohami and
VachaShah
as code owners
|
❌ Gradle check result for 464b4bf: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
❌ Gradle check result for 464b4bf: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
❌ Gradle check result for ac4e6a0: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
❌ Gradle check result for c903bef: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
❌ Gradle check result for ac4e6a0: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
❌ Gradle check result for c903bef: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Getting build failures despite branch up to date with mainline. |
|
Looks like other build are also facing same issue . This is happening locally as well . |
Signed-off-by: Gaurav Bafna <[email protected]>
Signed-off-by: Gaurav Bafna <[email protected]>
|
❌ Gradle check result for 77a9bf9: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #15037 +/- ##
============================================
- Coverage 71.82% 71.77% -0.06%
- Complexity 62778 62810 +32
============================================
Files 5169 5169
Lines 294646 294665 +19
Branches 42610 42616 +6
============================================
- Hits 211644 211497 -147
- Misses 65573 65800 +227
+ Partials 17429 17368 -61 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Gaurav Bafna <[email protected]> (cherry picked from commit 47171f8) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
(cherry picked from commit 47171f8) Signed-off-by: Gaurav Bafna <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…ject#15037) Signed-off-by: Gaurav Bafna <[email protected]>
…ject#15037) Signed-off-by: Gaurav Bafna <[email protected]>
…ject#15037) Signed-off-by: Gaurav Bafna <[email protected]>
Description
If we use async FS Repo , checksum comes null in a flaky way . To stop further build failures, i have set it to not use async FS Repo . This is what we are doing for
RemoteSplitIndexITas well and originally done in #13637The tricky thing is i am not able to repro why the checksum could come null even on 2.5k iterations and running . I will keep running this to see if it ever fails .
Related Issues
Resolves #14292
Check List
[ ] API changes companion pull request created, if applicable.Public documentation issue/PR created, if applicable.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.