Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Reduce logging in DEBUG for MasterService:run #14864

Merged

Conversation

sumitasr
Copy link
Member

Reduce logging in DEBUG for MasterService:run (#14795)

  • Reduce logging in DEBUG for MasteService:run by introducing short and long summary in Taskbatcher

Signed-off-by: Sumit Bansal [email protected]
(cherry picked from commit b35690c)

* Reduce logging in DEBUG for MasteService:run by introducing short and long summary in Taskbatcher

Signed-off-by: Sumit Bansal <[email protected]>
(cherry picked from commit b35690c)
@sumitasr sumitasr changed the title Reduce logging in DEBUG for MasterService:run (#14795) [Backport] Reduce logging in DEBUG for MasterService:run (#14795) Jul 22, 2024
@sumitasr sumitasr changed the title [Backport] Reduce logging in DEBUG for MasterService:run (#14795) [Backport 2.x] Reduce logging in DEBUG for MasterService:run (#14795) Jul 22, 2024
@sumitasr sumitasr marked this pull request as ready for review July 22, 2024 17:30
@sumitasr sumitasr changed the title [Backport 2.x] Reduce logging in DEBUG for MasterService:run (#14795) [Backport 2.x] Reduce logging in DEBUG for MasterService:run Jul 22, 2024
Copy link
Contributor

❕ Gradle check result for 01e6be4: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

Copy link

codecov bot commented Jul 22, 2024

Codecov Report

Attention: Patch coverage is 96.77419% with 1 line in your changes missing coverage. Please review.

Project coverage is 71.51%. Comparing base (7755055) to head (5325ac6).
Report is 3 commits behind head on 2.x.

Files Patch % Lines
...va/org/opensearch/cluster/service/TaskBatcher.java 92.30% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                2.x   #14864      +/-   ##
============================================
- Coverage     71.58%   71.51%   -0.07%     
+ Complexity    62544    62527      -17     
============================================
  Files          5108     5109       +1     
  Lines        293645   293624      -21     
  Branches      42781    42789       +8     
============================================
- Hits         210205   209989     -216     
- Misses        65741    66018     +277     
+ Partials      17699    17617      -82     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dbwiddis
Copy link
Member

@sumitasr does this need to be backported to 2.16? If so please add that label

@sumitasr
Copy link
Member Author

@sumitasr does this need to be backported to 2.16? If so please add that label

@dbwiddis Yes, this is intended for 2.16 release. I don't have permissions to add label. This is manual backport i had to raise for original #14795 which had the 2.16 label.

Can you please help?

Copy link
Contributor

❕ Gradle check result for 5325ac6: UNSTABLE

  • TEST FAILURES:
      1 org.opensearch.repositories.azure.AzureBlobContainerRetriesTests.testReadRangeBlobWithRetries
      1 org.opensearch.repositories.azure.AzureBlobContainerRetriesTests.testReadBlobWithRetries

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

@dbwiddis dbwiddis merged commit 7e7e775 into opensearch-project:2.x Jul 22, 2024
34 of 35 checks passed
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.16 failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-2.16 2.16
# Navigate to the new working tree
pushd ../.worktrees/backport-2.16
# Create a new branch
git switch --create backport/backport-14864-to-2.16
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 7e7e77504c6a0f20b3ba49786057ab906b9ea880
# Push it to GitHub
git push --set-upstream origin backport/backport-14864-to-2.16
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-2.16

Then, create a pull request where the base branch is 2.16 and the compare/head branch is backport/backport-14864-to-2.16.

sumitasr added a commit to sumitasr/OpenSearch that referenced this pull request Jul 22, 2024
…) (opensearch-project#14864)

* Reduce logging in DEBUG for MasteService:run by introducing short and long summary in Taskbatcher

Signed-off-by: Sumit Bansal <[email protected]>
(cherry picked from commit b35690c)

Signed-off-by: Sumit Bansal <[email protected]>
(cherry picked from commit 7e7e775)
dblock pushed a commit that referenced this pull request Jul 22, 2024
* Reduce logging in DEBUG for MasteService:run by introducing short and long summary in Taskbatcher

Signed-off-by: Sumit Bansal <[email protected]>
(cherry picked from commit b35690c)

Signed-off-by: Sumit Bansal <[email protected]>
(cherry picked from commit 7e7e775)
@dblock dblock added the v2.16.0 Issues and PRs related to version 2.16.0 label Jul 23, 2024
kkewwei pushed a commit to kkewwei/OpenSearch that referenced this pull request Jul 24, 2024
…) (opensearch-project#14864)

* Reduce logging in DEBUG for MasteService:run by introducing short and long summary in Taskbatcher

Signed-off-by: Sumit Bansal <[email protected]>
(cherry picked from commit b35690c)

Signed-off-by: Sumit Bansal <[email protected]>
Signed-off-by: kkewwei <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.16 v2.16.0 Issues and PRs related to version 2.16.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants