Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set INDICES_MAX_CLAUSE_COUNT dynamically #13568

Merged
merged 12 commits into from
Jun 18, 2024

Conversation

harshavamsi
Copy link
Contributor

@harshavamsi harshavamsi commented May 6, 2024

Description

Changes the INDICES_MAX_CLAUSE_COUNT_SETTING to be dynamic instead of being static.

This PR is virtually identical to #1527, but there was earlier push back around making this an updateable dynamic setting due to the assumption that users would abuse this setting rather than optimize their underlying query. Lucene has since updated the way the clause counts work and this is now enforced at the indexSearcher level -- https://issues.apache.org/jira/browse/LUCENE-8811.

More info can be found in #12549 around the motivation for this change, but I ended up raising a PR to make a simple dynamic setting.

Related Issues

Resolves #1526 #12549

Check List

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Harsha Vamsi Kalluri <[email protected]>
Copy link
Contributor

github-actions bot commented May 6, 2024

❌ Gradle check result for dd140e2: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

github-actions bot commented May 7, 2024

❌ Gradle check result for 28d5525: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Signed-off-by: Harsha Vamsi Kalluri <[email protected]>
@reta reta added the v2.16.0 Issues and PRs related to version 2.16.0 label Jun 13, 2024
CHANGELOG.md Show resolved Hide resolved
@reta
Copy link
Collaborator

reta commented Jun 13, 2024

2.15.0 has sailed away, targeting this change to 2.16.0

Copy link
Contributor

✅ Gradle check result for cd92a9b: SUCCESS

@github-actions github-actions bot added the v3.0.0 Issues and PRs related to version 3.0.0 label Jun 13, 2024
Signed-off-by: Harsha Vamsi Kalluri <[email protected]>
Copy link
Contributor

❌ Gradle check result for b221209: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for e715516: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@harshavamsi
Copy link
Contributor Author

Opened https://github.com/opensearch-project/documentation-website/pull/7391/files

Copy link
Contributor

❌ Gradle check result for e715516: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@harshavamsi
Copy link
Contributor Author

❌ Gradle check result for e715516: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

#14300
#12651
@msfroh can we merge?

Copy link
Contributor

✅ Gradle check result for e715516: SUCCESS

@msfroh msfroh merged commit c5c6024 into opensearch-project:main Jun 18, 2024
32 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jun 18, 2024
---------

Signed-off-by: Harsha Vamsi Kalluri <[email protected]>
(cherry picked from commit c5c6024)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@harshavamsi harshavamsi deleted the dynamic_max_clause branch June 18, 2024 18:38
dblock pushed a commit that referenced this pull request Jun 19, 2024
---------


(cherry picked from commit c5c6024)

Signed-off-by: Harsha Vamsi Kalluri <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
harshavamsi added a commit to harshavamsi/OpenSearch that referenced this pull request Jul 12, 2024
kkewwei pushed a commit to kkewwei/OpenSearch that referenced this pull request Jul 24, 2024
…pensearch-project#14436)

---------

(cherry picked from commit c5c6024)

Signed-off-by: Harsha Vamsi Kalluri <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Signed-off-by: kkewwei <[email protected]>
wdongyu pushed a commit to wdongyu/OpenSearch that referenced this pull request Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch enhancement Enhancement or improvement to existing feature or request Search Search query, autocomplete ...etc v2.16.0 Issues and PRs related to version 2.16.0 v3.0.0 Issues and PRs related to version 3.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dynamic max boolean clause counts
4 participants