Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace the right version to fix backward compatibility introduced wi… #13168

Merged
merged 1 commit into from
Apr 11, 2024

Conversation

rishabhmaurya
Copy link
Contributor

…th DerivedFields feature

Description

Fixes backward compatibility issues which was introduced in #12850

Related Issues

Resolves #[Issue number to be closed when this PR is merged]

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
  • Commits are signed per the DCO using --signoff
  • [ ] Commit changes are listed out in CHANGELOG.md file (See: Changelog)
  • [ ] Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

…th DerivedFields feature

Signed-off-by: Rishabh Maurya <[email protected]>
Copy link
Contributor

Compatibility status:

Checks if related components are compatible with change 3c6dbf0

Incompatible components

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/flow-framework.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/sql.git]

Copy link
Contributor

❌ Gradle check result for 3c6dbf0: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@msfroh
Copy link
Collaborator

msfroh commented Apr 11, 2024

I just merged #13163 and retried the Gradle check here

Copy link
Contributor

❌ Gradle check result for 3c6dbf0: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@owaiskazi19
Copy link
Member

Looks like a node connection exception. Will try check again

Copy link
Contributor

✅ Gradle check result for 3c6dbf0: SUCCESS

Copy link

codecov bot commented Apr 11, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 71.51%. Comparing base (b15cb0c) to head (3c6dbf0).
Report is 154 commits behind head on main.

Files Patch % Lines
...opensearch/search/builder/SearchSourceBuilder.java 0.00% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main   #13168      +/-   ##
============================================
+ Coverage     71.42%   71.51%   +0.09%     
- Complexity    59978    60566     +588     
============================================
  Files          4985     5033      +48     
  Lines        282275   284903    +2628     
  Branches      40946    41286     +340     
============================================
+ Hits         201603   203745    +2142     
- Misses        63999    64204     +205     
- Partials      16673    16954     +281     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@reta
Copy link
Collaborator

reta commented Apr 11, 2024

❌ Gradle check result for 3c6dbf0: FAILURE

#11483
#10152

@reta reta merged commit 02e3c56 into opensearch-project:main Apr 11, 2024
82 of 84 checks passed
shiv0408 pushed a commit to Gaurav614/OpenSearch that referenced this pull request Apr 25, 2024
…th DerivedFields feature (opensearch-project#13168)

Signed-off-by: Rishabh Maurya <[email protected]>
Signed-off-by: Shivansh Arora <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants