Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport 2.x] Catch task description error (#12834) #12858

Merged
merged 1 commit into from
Mar 25, 2024
Merged

[Backport 2.x] Catch task description error (#12834) #12858

merged 1 commit into from
Mar 25, 2024

Conversation

dblock
Copy link
Member

@dblock dblock commented Mar 22, 2024

Description

Backports #12834 to 2.x.

Related Issues

Closes #11688
Closes #12324

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)
  • Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@dblock dblock mentioned this pull request Mar 22, 2024
Merged
8 tasks
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 22, 2024 •
edited
Loading

Compatibility status:

Checks if related components are compatible with change 7f0fe66

Incompatible components

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/flow-framework.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/performance-analyzer.git]

@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for 1e8ee68: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@dblock
Copy link
Member Author

dblock commented Mar 22, 2024

❌ Gradle check result for 1e8ee68: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

org.opensearch.index.shard.RemoteStoreRefreshListenerTests.testRefreshAfterCommit
org.opensearch.index.shard.RemoteStoreRefreshListenerTests.testAfterRefresh
org.opensearch.index.shard.RemoteStoreRefreshListenerTests.testAfterCommit
org.opensearch.index.shard.RemoteStoreRefreshListenerTests.testAfterMultipleCommits
org.opensearch.index.shard.RemoteStoreRefreshListenerTests.testRefreshAfterCommit
org.opensearch.index.shard.RemoteStoreRefreshListenerTests.classMethod
org.opensearch.index.shard.RemoteStoreRefreshListenerTests.classMethod

#8946

@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for 1e8ee68: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@reta
Copy link
Collaborator

reta commented Mar 22, 2024 •
edited
Loading

❌ Gradle check result for 1e8ee68: FAILURE

#12861 (@dblock it seems we have a new variation of failures, I created a new issue to track that)

@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for 1e8ee68: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@reta
Copy link
Collaborator

reta commented Mar 22, 2024

❌ Gradle check result for 1e8ee68: FAILURE

#10945
#12861

@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for 1e8ee68: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@reta
Copy link
Collaborator

reta commented Mar 22, 2024

❌ Gradle check result for 1e8ee68: FAILURE

#12861

@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for 1e8ee68: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@reta
Copy link
Collaborator

reta commented Mar 22, 2024

❌ Gradle check result for 1e8ee68: FAILURE

#12861

@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for 1e8ee68: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@reta
Copy link
Collaborator

reta commented Mar 23, 2024

@dblock needs rebase please

@dblock
Catch task description error (opensearch-project#12834)
7f0fe66 
* Always return a task description even when it cannot be serialized.

Signed-off-by: dblock <[email protected]>

* Expect tasks to fail.

Signed-off-by: dblock <[email protected]>

* Only catch exceptions when getting description.

Signed-off-by: dblock <[email protected]>

* Added <error: ...> to mark error more clearly.

Signed-off-by: dblock <[email protected]>

---------

Signed-off-by: dblock <[email protected]>
(cherry picked from commit 0c956e8)
@dblock dblock force-pushed the backport/backport-12834-to-2.x branch from 1e8ee68 to 7f0fe66 Compare March 25, 2024 20:08
@github-actions GitHub Actions
Copy link
Contributor

✅ Gradle check result for 7f0fe66: SUCCESS

@reta reta self-requested a review March 25, 2024 21:37
@reta reta merged commit 64945ba into opensearch-project:2.x Mar 25, 2024
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reta reta reta approved these changes

@abbashus abbashus Awaiting requested review from abbashus

@adnapibar adnapibar Awaiting requested review from adnapibar

@anasalkouz anasalkouz Awaiting requested review from anasalkouz anasalkouz is a code owner

@andrross andrross Awaiting requested review from andrross andrross is a code owner

@Bukhtawar Bukhtawar Awaiting requested review from Bukhtawar Bukhtawar is a code owner

@CEHENKLE CEHENKLE Awaiting requested review from CEHENKLE CEHENKLE is a code owner

@dbwiddis dbwiddis Awaiting requested review from dbwiddis dbwiddis is a code owner

@dreamer-89 dreamer-89 Awaiting requested review from dreamer-89

@gbbafna gbbafna Awaiting requested review from gbbafna gbbafna is a code owner

@kotwanikunal kotwanikunal Awaiting requested review from kotwanikunal kotwanikunal is a code owner

@mch2 mch2 Awaiting requested review from mch2 mch2 is a code owner

@msfroh msfroh Awaiting requested review from msfroh msfroh is a code owner

@nknize nknize Awaiting requested review from nknize nknize is a code owner

@owaiskazi19 owaiskazi19 Awaiting requested review from owaiskazi19 owaiskazi19 is a code owner

@Rishikesh1159 Rishikesh1159 Awaiting requested review from Rishikesh1159 Rishikesh1159 is a code owner

@ryanbogan ryanbogan Awaiting requested review from ryanbogan

@sachinpkale sachinpkale Awaiting requested review from sachinpkale sachinpkale is a code owner

@saratvemulapalli saratvemulapalli Awaiting requested review from saratvemulapalli saratvemulapalli is a code owner

@shwetathareja shwetathareja Awaiting requested review from shwetathareja shwetathareja is a code owner

@sohami sohami Awaiting requested review from sohami sohami is a code owner

@tlfeng tlfeng Awaiting requested review from tlfeng

@VachaShah VachaShah Awaiting requested review from VachaShah VachaShah is a code owner

Assignees
No one assigned
Labels
skip-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dblock @reta