Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use async write for manifest file and use latch for timeout #10968

Merged
merged 3 commits into from
Oct 30, 2023
Merged

Use async write for manifest file and use latch for timeout #10968

merged 3 commits into from
Oct 30, 2023

Conversation

dhwanilpatel
Copy link
Contributor

@dhwanilpatel dhwanilpatel commented Oct 27, 2023 •
edited
Loading

Description

Use async write for Manifest file.
Use latch for maintaining timeout for file transfer of manifest file.

Related Issues

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog) [Not required]
  • Public documentation issue/PR created [Not required]

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 27, 2023 •
edited
Loading

Compatibility status:

Checks if related components are compatible with change 2ec4478

Incompatible components

Incompatible components: [https://github.com/opensearch-project/performance-analyzer.git]

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/neural-search.git]

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@dhwanilpatel
Incorporated comments
530bbb6 
Signed-off-by: Dhwanil Patel <[email protected]>
@dhwanilpatel dhwanilpatel marked this pull request as ready for review October 30, 2023 05:52
linuxpi
linuxpi approved these changes Oct 30, 2023
View reviewed changes
Copy link
Collaborator

@linuxpi linuxpi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one minor comment around adding trace log!

@dhwanilpatel
Add trace log
2ec4478 
Signed-off-by: Dhwanil Patel <[email protected]>
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      1 org.opensearch.index.ShardIndexingPressureSettingsIT.testShardIndexingPressureLastSuccessfulSettingsUpdate

@codecov
Copy link

codecov bot commented Oct 30, 2023 •
edited
Loading

Codecov Report

Merging #10968 (2ec4478) into main (be65f54) will increase coverage by 0.14%.
Report is 5 commits behind head on main.
The diff coverage is 64.70%.

@@             Coverage Diff              @@
##               main   #10968      +/-   ##
============================================
+ Coverage     71.21%   71.36%   +0.14%     
- Complexity    58689    58762      +73     
============================================
  Files          4870     4870              
  Lines        276539   276560      +21     
  Branches      40190    40192       +2     
============================================
+ Hits         196945   197369     +424     
+ Misses        63192    62746     -446     
- Partials      16402    16445      +43
Files Coverage Δ
...rg/opensearch/common/settings/ClusterSettings.java 92.85% <ø> (ø)
...arch/gateway/remote/RemoteClusterStateService.java 72.69% <64.70%> (+0.14%) ⬆️

... and 451 files with indirect coverage changes

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      1 org.opensearch.remotestore.RemoteStoreStatsIT.testNonZeroPrimaryStatsOnNewlyCreatedIndexWithZeroDocs

@dhwanilpatel dhwanilpatel mentioned this pull request Oct 30, 2023
Closed
@dhwanilpatel
Copy link
Contributor Author

Unrelated flaky test: org.opensearch.remotestore.RemoteStoreStatsIT.testNonZeroPrimaryStatsOnNewlyCreatedIndexWithZeroDocs

Created github issue: #10983

@shwetathareja shwetathareja merged commit 84be8c9 into opensearch-project:main Oct 30, 2023
22 of 26 checks passed
@shwetathareja shwetathareja added the backport 2.x Backport to 2.x branch label Oct 30, 2023
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 30, 2023
@github-actions
Use async write for manifest file and use latch for timeout (#10968)
4da30f4 
* Use async write for manifest file and use latch for timeout

Signed-off-by: Dhwanil Patel <[email protected]>
(cherry picked from commit 84be8c9)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Oct 30, 2023
Merged
shwetathareja pushed a commit that referenced this pull request Oct 30, 2023
@opensearch-trigger-bot @github-actions
Use async write for manifest file and use latch for timeout (#10968) (#…
52ec075 
…10984)

* Use async write for manifest file and use latch for timeout

(cherry picked from commit 84be8c9)

Signed-off-by: Dhwanil Patel <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
shiv0408 pushed a commit to Gaurav614/OpenSearch that referenced this pull request Apr 25, 2024
@dhwanilpatel @shiv0408
Use async write for manifest file and use latch for timeout (opensear…
4f29d7e 
…ch-project#10968)

* Use async write for manifest file and use latch for timeout

Signed-off-by: Dhwanil Patel <[email protected]>
Signed-off-by: Shivansh Arora <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shwetathareja shwetathareja shwetathareja approved these changes

@linuxpi linuxpi linuxpi approved these changes

@abbashus abbashus Awaiting requested review from abbashus

@anasalkouz anasalkouz Awaiting requested review from anasalkouz anasalkouz is a code owner

@andrross andrross Awaiting requested review from andrross andrross is a code owner

@Bukhtawar Bukhtawar Awaiting requested review from Bukhtawar Bukhtawar is a code owner

@CEHENKLE CEHENKLE Awaiting requested review from CEHENKLE CEHENKLE is a code owner

@dblock dblock Awaiting requested review from dblock dblock is a code owner

@dbwiddis dbwiddis Awaiting requested review from dbwiddis dbwiddis is a code owner

@dreamer-89 dreamer-89 Awaiting requested review from dreamer-89

@gbbafna gbbafna Awaiting requested review from gbbafna gbbafna is a code owner

@kartg kartg Awaiting requested review from kartg

@kotwanikunal kotwanikunal Awaiting requested review from kotwanikunal kotwanikunal is a code owner

@mch2 mch2 Awaiting requested review from mch2 mch2 is a code owner

@msfroh msfroh Awaiting requested review from msfroh msfroh is a code owner

@nknize nknize Awaiting requested review from nknize nknize is a code owner

@owaiskazi19 owaiskazi19 Awaiting requested review from owaiskazi19 owaiskazi19 is a code owner

@peternied peternied Awaiting requested review from peternied

@reta reta Awaiting requested review from reta reta is a code owner

@Rishikesh1159 Rishikesh1159 Awaiting requested review from Rishikesh1159 Rishikesh1159 is a code owner

@ryanbogan ryanbogan Awaiting requested review from ryanbogan

@sachinpkale sachinpkale Awaiting requested review from sachinpkale sachinpkale is a code owner

@saratvemulapalli saratvemulapalli Awaiting requested review from saratvemulapalli saratvemulapalli is a code owner

@setiah setiah Awaiting requested review from setiah

@sohami sohami Awaiting requested review from sohami sohami is a code owner

@VachaShah VachaShah Awaiting requested review from VachaShah VachaShah is a code owner

Assignees
No one assigned
Labels
backport 2.x Backport to 2.x branch skip-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dhwanilpatel @shwetathareja @linuxpi