Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace spritezero with spreet #442

Merged
merged 1 commit into from
Feb 19, 2024
Merged

Conversation

handymenny
Copy link
Contributor

@handymenny handymenny commented Feb 18, 2024

spreet is a command-line tool that creates sprites.

Why spreet over spritezero?

The first is the most important reason, it fixes openmaptiles/openmaptiles#1549, superseding openmaptiles/openmaptiles#1580 and https://github.com/openmaptiles/spritezero/pull/1

@lazaa32
Copy link
Collaborator

lazaa32 commented Feb 19, 2024

Hi @handymenny
the spreet tool seems very good to me. Glad we do not have to use two other forks to get spritezero working.

Could you please create a related PR into OMT, that in Makefile replaces spritezero with spreet and use the correct order of and ? Thanks!

@handymenny
Copy link
Contributor Author

Could you please create a related PR into OMT, that in Makefile replaces spritezero with spreet and use the correct order of and ?

Done

Copy link
Collaborator

@lazaa32 lazaa32 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much!

@lazaa32 lazaa32 merged commit ddd067d into openmaptiles:master Feb 19, 2024
1 check passed
TomPohys pushed a commit to openmaptiles/openmaptiles that referenced this pull request Feb 26, 2024
This updates `build-sprite` and `build-style` to use `spreet`.

It depends on openmaptiles/openmaptiles-tools#442
francois2metz pushed a commit to indoorequal/openmaptiles-tools that referenced this pull request Apr 5, 2024
ijo42 pushed a commit to psumaps/openmaptiles-tools that referenced this pull request May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sprite conversion fails for some SVG icons
2 participants