Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix markdown linter checkout err #1638

Merged
merged 1 commit into from
Jun 4, 2024

Conversation

ABNER-1
Copy link
Member

@ABNER-1 ABNER-1 commented Jun 3, 2024

Ⅰ. Describe what this PR does

use checkout v3 in ci job "markdownlint-misspell-shellcheck"

Ⅱ. Does this pull request fix one issue?

fix #1637

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

@kruise-bot kruise-bot added the size/XS size/XS: 0-9 label Jun 3, 2024
Copy link

codecov bot commented Jun 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 48.96%. Comparing base (0d0031a) to head (4e6ffd9).
Report is 38 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1638      +/-   ##
==========================================
+ Coverage   47.91%   48.96%   +1.04%     
==========================================
  Files         162      180      +18     
  Lines       23491    18804    -4687     
==========================================
- Hits        11256     9207    -2049     
+ Misses      11014     8380    -2634     
+ Partials     1221     1217       -4     
Flag Coverage Δ
unittests 48.96% <ø> (+1.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kruise-bot kruise-bot added size/S size/S 10-29 and removed size/XS size/XS: 0-9 labels Jun 4, 2024
@furykerry
Copy link
Member

/lgtm
/approve

@kruise-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: furykerry

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kruise-bot kruise-bot merged commit 1045e6c into openkruise:master Jun 4, 2024
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] markdownlint-misspell-shellcheck always failed in e2e when use checkout@v4
3 participants