feat: Support run e2e test casese in local #1316

Hinsteny · 2023-06-15T10:55:05Z

Ⅰ. Describe what this PR does

Support run e2e test casese in local

Ⅱ. Does this pull request fix one issue?

No

Ⅲ. Describe how to verify it

just run e2e test command at local

make kruise-e2e-test

Ⅳ. Special notes for reviews

No

kruise-bot · 2023-06-15T10:55:21Z

Welcome @Hinsteny! It looks like this is your first PR to openkruise/kruise 🎉

zmberg · 2023-06-15T10:57:19Z

just run e2e test command at local

What is 'at local', can you describe the background?

tools/src/kind/go.mod

@@ -0,0 +1,22 @@
+module github.com/envoyproxy/gateway/tools/src/kind


Hinsteny · 2023-06-15T11:03:27Z

just run e2e test command at local

What is 'at local', can you describe the background?

That means on the developer user's local computer.

codecov-commenter · 2023-06-15T11:08:53Z

Codecov Report

Merging #1316 (334edb9) into master (ffcf189) will not change coverage.
The diff coverage is n/a.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@           Coverage Diff           @@
##           master    #1316   +/-   ##
=======================================
  Coverage   48.50%   48.50%           
=======================================
  Files         151      151           
  Lines       21210    21210           
=======================================
  Hits        10288    10288           
  Misses       9793     9793           
  Partials     1129     1129

Flag	Coverage Δ
unittests	`48.50% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

sonatype-lift · 2023-06-15T11:19:22Z

tools/hack/run-kruise-e2e-test.sh

+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+#!/usr/bin/env bash


SC1128: The shebang must be on the first line. Delete blanks and move comments.

❗❗ 3 similar findings have been found in this PR

🔎 Expand here to view all instances of this finding

File Path Line Number

tools/hack/kind-load-image.sh 15

tools/hack/install-kruise.sh 15

tools/hack/create-cluster.sh 15

Visit the Lift Web Console to find more details in your report.

ℹ️ Expand to see all @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage

@sonatype-lift ignore Leave out the above finding from this PR

@sonatype-lift ignoreall Leave out all the existing findings from this PR

@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
_{Click here to add LiftBot to another repo.}

sonatype-lift · 2023-06-15T11:19:24Z

tools/hack/install-kruise.sh

+for ((i=1;i<10;i++));
+do
+  set +e
+  PODS=$(kubectl get pod -n kruise-system | grep '1/1' | wc -l)


SC2126: Consider using grep -c instead of grep|wc -l.

ℹ️ Expand to see all @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage

@sonatype-lift ignore Leave out the above finding from this PR

@sonatype-lift ignoreall Leave out all the existing findings from this PR

@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
_{Click here to add LiftBot to another repo.}

sonatype-lift · 2023-06-15T11:19:26Z

tools/hack/install-kruise.sh

+  sleep 3
+done
+set +e
+PODS=$(kubectl get pod -n kruise-system | grep '1/1' | wc -l)


SC2126: Consider using grep -c instead of grep|wc -l.

ℹ️ Expand to see all @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage

@sonatype-lift ignore Leave out the above finding from this PR

@sonatype-lift ignoreall Leave out all the existing findings from this PR

@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
_{Click here to add LiftBot to another repo.}

sonatype-lift · 2023-06-15T11:19:28Z

tools/hack/create-cluster.sh

+# Setup default values
+CLUSTER_NAME=${CLUSTER_NAME:-"ci-testing"}
+KIND_NODE_TAG=${KIND_NODE_TAG:-"v1.24.2"}
+PROJECT_DIR=$(pwd)


SC2034: PROJECT_DIR appears unused. Verify use (or export if used externally).

ℹ️ Expand to see all @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage

@sonatype-lift ignore Leave out the above finding from this PR

@sonatype-lift ignoreall Leave out all the existing findings from this PR

@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
_{Click here to add LiftBot to another repo.}

sonatype-lift · 2023-06-15T11:19:30Z

tools/hack/create-cluster.sh

+KIND_NODE_TAG=${KIND_NODE_TAG:-"v1.24.2"}
+PROJECT_DIR=$(pwd)
+
+echo ${KIND_NODE_TAG}


SC2086: Double quote to prevent globbing and word splitting.

ℹ️ Expand to see all @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage

@sonatype-lift ignore Leave out the above finding from this PR

@sonatype-lift ignoreall Leave out all the existing findings from this PR

@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
_{Click here to add LiftBot to another repo.}

sonatype-lift · 2023-06-15T11:19:31Z

tools/hack/create-cluster.sh

+PROJECT_DIR=$(pwd)
+
+echo ${KIND_NODE_TAG}
+echo ${CLUSTER_NAME}


SC2086: Double quote to prevent globbing and word splitting.

ℹ️ Expand to see all @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage

@sonatype-lift ignore Leave out the above finding from this PR

@sonatype-lift ignoreall Leave out all the existing findings from this PR

@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
_{Click here to add LiftBot to another repo.}

zmberg · 2023-06-15T11:56:26Z

@Hinsteny The follow auto-checks fails, and you need to resolve them.

Signed-off-by: Hinsteny <[email protected]>

Hinsteny · 2023-06-19T07:22:47Z

@Hinsteny The follow auto-checks fails, and you need to resolve them.

@zmberg Please help me review again.

zmberg · 2023-06-25T09:14:59Z

/lgtm

zmberg · 2023-06-26T07:35:46Z

/approve

kruise-bot · 2023-06-26T07:35:51Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zmberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [zmberg]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Signed-off-by: Hinsteny <[email protected]>

kruise-bot requested review from furykerry and zmberg June 15, 2023 10:55

kruise-bot added the size/L size/L: 100-499 label Jun 15, 2023

github-advanced-security bot found potential problems Jun 15, 2023

View reviewed changes

Hinsteny force-pushed the feat_local_e2e_test branch 2 times, most recently from c0732d1 to 08da197 Compare June 15, 2023 11:00

sonatype-lift bot reviewed Jun 15, 2023

View reviewed changes

Hinsteny force-pushed the feat_local_e2e_test branch from 08da197 to 334edb9 Compare June 19, 2023 06:21

feat: Support run e2e test casese in local

1510617

Signed-off-by: Hinsteny <[email protected]>

Hinsteny force-pushed the feat_local_e2e_test branch from 334edb9 to 1510617 Compare June 19, 2023 06:38

kruise-bot assigned zmberg Jun 25, 2023

kruise-bot added the lgtm label Jun 25, 2023

kruise-bot added the approved label Jun 26, 2023

kruise-bot merged commit ffe60f2 into openkruise:master Jun 26, 2023
6 checks passed

diannaowa pushed a commit to diannaowa/kruise that referenced this pull request Aug 29, 2023

feat: Support run e2e test casese in local (openkruise#1316)

3a53405

Signed-off-by: Hinsteny <[email protected]>

lilongfeng0902 pushed a commit to lilongfeng0902/kruise that referenced this pull request Sep 12, 2023

feat: Support run e2e test casese in local (openkruise#1316)

e5d99e9

Signed-off-by: Hinsteny <[email protected]>

ppbits pushed a commit to ppbits/kruise that referenced this pull request Apr 4, 2024

feat: Support run e2e test casese in local (openkruise#1316)

12440b3

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Support run e2e test casese in local #1316

feat: Support run e2e test casese in local #1316

Hinsteny commented Jun 15, 2023

kruise-bot commented Jun 15, 2023

zmberg commented Jun 15, 2023 •

edited

Loading

Hinsteny commented Jun 15, 2023

codecov-commenter commented Jun 15, 2023 •

edited

Loading

sonatype-lift bot Jun 15, 2023

sonatype-lift bot Jun 15, 2023

sonatype-lift bot Jun 15, 2023

sonatype-lift bot Jun 15, 2023

sonatype-lift bot Jun 15, 2023

sonatype-lift bot Jun 15, 2023

zmberg commented Jun 15, 2023

Hinsteny commented Jun 19, 2023

zmberg commented Jun 25, 2023

zmberg commented Jun 26, 2023

kruise-bot commented Jun 26, 2023

		@@ -0,0 +1,22 @@
		module github.com/envoyproxy/gateway/tools/src/kind

File Path	Line Number
tools/hack/kind-load-image.sh	15
tools/hack/install-kruise.sh	15
tools/hack/create-cluster.sh	15

Command	Usage
`@sonatype-lift ignore`	Leave out the above finding from this PR
`@sonatype-lift ignoreall`	Leave out all the existing findings from this PR
`@sonatype-lift exclude <file\|issue\|path\|tool>`	Exclude specified `file\|issue\|path\|tool` from Lift findings by updating your config.toml file

feat: Support run e2e test casese in local #1316

feat: Support run e2e test casese in local #1316

Conversation

Hinsteny commented Jun 15, 2023

Ⅰ. Describe what this PR does

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

kruise-bot commented Jun 15, 2023

zmberg commented Jun 15, 2023 • edited Loading

Hinsteny commented Jun 15, 2023

codecov-commenter commented Jun 15, 2023 • edited Loading

Codecov Report

sonatype-lift bot Jun 15, 2023

Choose a reason for hiding this comment

sonatype-lift bot Jun 15, 2023

Choose a reason for hiding this comment

sonatype-lift bot Jun 15, 2023

Choose a reason for hiding this comment

sonatype-lift bot Jun 15, 2023

Choose a reason for hiding this comment

sonatype-lift bot Jun 15, 2023

Choose a reason for hiding this comment

sonatype-lift bot Jun 15, 2023

Choose a reason for hiding this comment

zmberg commented Jun 15, 2023

Hinsteny commented Jun 19, 2023

zmberg commented Jun 25, 2023

zmberg commented Jun 26, 2023

kruise-bot commented Jun 26, 2023

zmberg commented Jun 15, 2023 •

edited

Loading

codecov-commenter commented Jun 15, 2023 •

edited

Loading