Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8338867: GenShen: Do all size accounting in words #482

Draft
wants to merge 75 commits into
base: master
Choose a base branch
from

Conversation

kdnilsen
Copy link
Contributor

@kdnilsen kdnilsen commented Aug 22, 2024

Draft while I work through the details of this

We want to consistently do all size accounting in words rather than a mix of bytes and words. This will affect both traditional Shenandoah and Generational Shenandoah implementations.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed (1 review required, with at least 1 Committer)

Issue

  • JDK-8338867: GenShen: Do all size accounting in words (Enhancement - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/shenandoah.git pull/482/head:pull/482
$ git checkout pull/482

Update a local copy of the PR:
$ git checkout pull/482
$ git pull https://git.openjdk.org/shenandoah.git pull/482/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 482

View PR using the GUI difftool:
$ git pr show -t 482

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/shenandoah/pull/482.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 22, 2024

👋 Welcome back kdnilsen! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Aug 22, 2024

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk
Copy link

openjdk bot commented Aug 22, 2024

@kdnilsen this pull request can not be integrated into master due to one or more merge conflicts. To resolve these merge conflicts and update this pull request you can run the following commands in the local repository for your personal fork:

git checkout do-all-size-accounting-in-words
git fetch https://git.openjdk.org/shenandoah.git master
git merge FETCH_HEAD
# resolve conflicts and follow the instructions given by git merge
git commit -m "Merge master"
git push

@openjdk openjdk bot added the merge-conflict Pull request has merge conflict with target branch label Aug 22, 2024
@kdnilsen kdnilsen marked this pull request as draft August 22, 2024 15:50
Also fix typos in spelling of proper_unit_for_byte_size()
@kdnilsen kdnilsen changed the title Do all size accounting in words 8338867: GenShen: Do all size accounting in words Aug 22, 2024
@openjdk openjdk bot added the merge-conflict Pull request has merge conflict with target branch label Sep 4, 2024
@openjdk openjdk bot removed the merge-conflict Pull request has merge conflict with target branch label Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant