Multiple binding markdown fixes #17422
Conversation
Signed-off-by: Leo Siepel <[email protected]>
Signed-off-by: Leo Siepel <[email protected]>
lsiepel
requested review from
gbicskei,
ssalonen,
kaikreuzer,
andylintner,
ccutrer,
yfre,
jamesmelville,
cweitkamp,
theater,
clinique,
trokohl and
hmerk
as code owners
| @@ -87,7 +86,7 @@ At the very least, you cannot use repeating (111-11-111) or sequential (123-45-6 | |||
|
|
|||
| Other settings, such as using Fahrenheit temperatures and specifying the interface to advertise the HomeKit bridge are also illustrated in the following sample: | |||
|
|
|||
| ``` | |||
| ```perl | |||
There was a problem hiding this comment.
Why perl ?
Same question for the other places where you added it.
There was a problem hiding this comment.
.cfg files are not listed in the post that is used as base (for reference: openhab/openhab-docs#999)
As there does not seem to be a preferred one, i choose this as it seems a decent fit. For instance it uses the same comment #
But i'm, open for other suggestions.
| - `sendNotification(emailAddress, message)`: Send a notification to a _specific_ openHAB Cloud user. | ||
| - `sendBroadcastNotification(message)`: Send a broadcast notification to _all_ devices of _all_ users. | ||
| - `sendLogNotification(message)`: Send a log notification to the notifications list. Log notifications do not trigger a notification on the device. | ||
| * `sendNotification(emailAddress, message)`: Send a notification to a _specific_ openHAB Cloud user. |
There was a problem hiding this comment.
Why in the previous file (homekit) you replaced * by - and here you do the reverse. The rendering seems to be identical, no ?
There was a problem hiding this comment.
VS Code
The original value in homekit gave:
MD004/ul-style: Unordered list style [Expected: dash; Actual: asterisk]
The original value in openhabcloud gave:
MD004/ul-style: Unordered list style [Expected: asterisk; Actual: dash]
Both have the same issue/link: https://github.com/DavidAnson/markdownlint/blob/v0.35.0/doc/md004.md
I must admit i just applied the sugggestion here without looking into exact details why the markdownlint preferred different chars for a similar looking case, as it seemed fine. I have now looked into it in more detail and this is determined based on the first list in the readme. So it doesn't matter what char, as long as it is consistent in the particular file. As this solved the warnings, and the file is now consistent i think this is fine.
Signed-off-by: Leo Siepel <[email protected]>
docsfolder cuasing 404's.