fix: ensure number of non-editable fields did not change between subm…

…ission
opengovsg · Aug 22, 2024 · 1b3f291 · 1b3f291
1 parent e7418d5
commit 1b3f291
Showing 1 changed file with 14 additions and 0 deletions.
diff --git a/...pp/modules/submission/multirespondent-submission/multirespondent-submission.middleware.ts b/...pp/modules/submission/multirespondent-submission/multirespondent-submission.middleware.ts
@@ -461,6 +461,20 @@ export const validateMultirespondentSubmission = async (
                 const previousResponses =
                   previousSubmissionDecryptedContent.responses as ParsedClearFormFieldResponsesV3
 
+                const previousNonEditableFieldIdsWithResponses = Object.keys(
+                  previousResponses,
+                ).filter((fieldId) => !editableFieldIds.includes(fieldId))
+                if (
+                  previousNonEditableFieldIdsWithResponses.length !==
+                  nonEditableFieldIdsWithResponses.length
+                ) {
+                  return err(
+                    new ProcessingError(
+                      'Number of non-editable fields in previous submission does not match number of non-editable fields in current submission',
+                    ),
+                  )
+                }
+
                 return Result.combine(
                   nonEditableFieldIdsWithResponses.map((fieldId) => {
                     const incomingResField = req.body.responses[fieldId]