Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the
isInit()
implementation, it makes sense to pushreInit()
up into theofAbstractParameter
so it can also be done without unwrapping the parameter type. It can then also be applied onofParameterGroup
(where it reInits all the children).Added verbose logs to notify users that calling
reInit()
on the special-caseofParameter<void>
has no effect. (Also inverted the result ofofParameter<void>::isInit()
(from false to true) as the general use case of iterating a group will probably be to look for non-init values, so the<void>
types have more chances of being unobtrusive returning true).