-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Windows] load image with filenames other than english #7435
base: master
Are you sure you want to change the base?
Conversation
Hey @oxillo please check this PR when you have the time. I don't know much about windows but I've tried to fix path encodings there, it seems to be working. |
PS: there is a test there meant to be removed before merge |
I've finally got a windows machine and some time to advance on this PR and test. opinions are welcome @ofTheo @oxillo @artificiel @openframeworks/windows |
Hello @ofTheo I think this one is good to go. There is a test here: |
@danoli3 can you double check this one if you have the time? |
The idea behind this PR is to use std::filesystem::path object to store the filename until right up the freeimage function is called. FreeImage has some special functions to handle wstring, so they are called for windows, conserving original encoding.