-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate formatting to use ruff
#1935
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
@@ -98,7 +98,7 @@ def _get_installed_offxml_dir_paths() -> list[str]: | |||
|
|||
|
|||
def get_available_force_fields(full_paths=False): | |||
""" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the only auto-magic change I'm iffy on, and that's mostly because I didn't build docs locally
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm guessing in some situations it might prevent the /*.
in the docstring from causing havoc? Seems like enough of a technical benefit that it's worth the slight weirdness
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also replace `isort` Update duplicate linting action Revert, update config Fix
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I love seeing so many #noqa
s going away. But is there a way to keep this from moving the imports in the molecule cookbook?
@@ -98,7 +98,7 @@ def _get_installed_offxml_dir_paths() -> list[str]: | |||
|
|||
|
|||
def get_available_force_fields(full_paths=False): | |||
""" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm guessing in some situations it might prevent the /*.
in the docstring from causing havoc? Seems like enough of a technical benefit that it's worth the slight weirdness
"""The attribute of a parameter with an unspecified number of terms, where | ||
r"""The attribute of a parameter with an unspecified number of terms, where |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @mattwthompson!
I've been a little annoying with how slow some of the existing tools are to install and run, so I tried this out. It's pretty good.
$ time pre-commit run --all-files 13:46:43 ☁ ruff ☀ ruff.....................................................................Passed blacken-docs.............................................................Passed pre-commit run --all-files 0.58s user 0.27s system 161% cpu 0.526 total