Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Redesigning notifications] Unify and improve width and positioning of notifications/banners #493

Open
filipefurtad0 opened this issue Dec 13, 2023 · 4 comments
Assignees
Labels
Needs Design Work Potential Papercut Issues that might qualify as papercuts (0.5 days dev)

Comments

@filipefurtad0
Copy link

filipefurtad0 commented Dec 13, 2023

What is the need / problem?

There are at least three different designs for notifications (banners) now.
image
image

If an enterprise is added to the an order cycle as a distributor but has no payment/shipping methods set the then the following message will be displayed throughout all the admin pages:
The hub Distributor Name is listed in an active order cycle, but does not have valid shipping and payment methods. Until you set these up, customers will not be able to shop at this hub.

The message appears on all admin pages, and is persistent, i.e., it only disappears after clicking the Dismiss button.

image

Which type of users does this problem affect (and how many, if known)?

  • Hub Managers (MCFEs)
  • Instance Managers

Potential solutions that will solve the problem?

Proposal:

  • Banners should never be placed next to each other, but each banner gets it's own row.
  • Banners should have a uniform behaviour regarding their width:
    • Option A: Always make them span almost the full screen width (like ToS-banner does currently)
    • Option B: Make them as small as possible (like 'update successful' banner), but use full screen width, if needed. So the version of the 'active order cycle' warning shouldn't happen.

Previous proposal (outdated):

  • Move the issue back to the top of the screen, minimizing potential overlap with other relevant elements.

Connected wishlist and discovery discussions

Additional context

https://openfoodnetwork.slack.com/archives/C01CXQNJ1J6/p1702485996860259

PS: I think all flash messages now appear at the bottom, but some - like the one below - does disappear after 4 secs or so:

image

@filipefurtad0 filipefurtad0 added Potential Papercut Issues that might qualify as papercuts (0.5 days dev) Needs Design Work labels Dec 13, 2023
@filipefurtad0 filipefurtad0 changed the title [Redesigning superadmin notifications] Overlapping notification when enterprise on OC has no delivery/payment methods set [Redesigning notifications] Overlapping notification when enterprise on OC has no delivery/payment methods set Dec 13, 2023
@mariocarabotta mariocarabotta self-assigned this Dec 17, 2023
@mariocarabotta
Copy link

extra bit of info for context: I'm trying to replicate this, but having a bit of trouble. I might not have the right type of account / data.

If I try to add a distributor that has no shipping / payment method, it doesn't let me do that from the order cycle editing flow

Screenshot 2023-12-20 at 10 14 45

@drummer83
Copy link

Hi @mariocarabotta,
the required workflow is as follows:

  1. Set up payment and shipping methods.
  2. Set up the order cycle and select just one shipping or payment method in step 4.
  3. Go to enterprise settings -> shipping/payment methods.
  4. Select EDIT for the shipping/payment method you used in the order cycle.
    image
  5. Deactivate the checkbox for the hub you used for the order cycle.
    image
  6. Click Update.

You should now see the warning.

@mariocarabotta
Copy link

amazing, thank you!

@drummer83 drummer83 changed the title [Redesigning notifications] Overlapping notification when enterprise on OC has no delivery/payment methods set [Redesigning notifications] Unify and improve width and positioning of notifications/banners Dec 22, 2023
@drummer83
Copy link

I have updated the issue to include the design proposals from #11795, because it's very closely related.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Design Work Potential Papercut Issues that might qualify as papercuts (0.5 days dev)
Projects
Status: Design needed
Development

No branches or pull requests

4 participants