Alert user when error requesting a report

[dacook]

I'm not sure why, but Turbo was swallowing the unauthorized error, so I thought we should alert the user to help with debugging. Same with network error, it gave no feedback before.

I think this can be tested with Capybara in theory, but I haven't invested the time on it.

What should we test?

This occurs whenever submitting a form with Turbo. The best example is running any report.

There are three types of errors, I can think of a way to test two of them:

1. Network error: turn off wifi/disable network
2. Authorisation error: This can be tested with bug Asking a report has no result when the producer is set as profile only (doesn't sell products) #12835. Otherwise I think you could test this by log out in another tab then log in as a shopper
3. Other errors (eg 500)

[rioug]

Nice one ! we could probably do something a bit nicer than using an alert but that's better than nothing. I hate it when error get swallowed.

[rioug]

Actually it's causing issue on the bulk product page, if you try to update a product that will fails we get a 422 that we handle nicely on the UI. But with this change we now get an alert !

[dacook]

Oh, that makes sense, thanks for checking that out. It's worrying that the specs didn't pick that up!

[rioug]

Oh, that makes sense, thanks for checking that out. It's worrying that the specs didn't pick that up!

I think the system specs accept alert by default if no behaviour specified.