EWPP-4321: Ensure oe_theme favicons are used if the subtheme is configured to use them and doesn't provide them. #1492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nagyad
previously approved these changes
Sep 2, 2024
intelektron
requested changes
Sep 5, 2024
oe_theme.theme
Outdated
| foreach ($attachments['#attached']['html_head_link'] as &$link) { | ||
| if ($link[0]['rel'] !== 'icon') { | ||
| continue; | ||
| } | ||
| $link[0]['href'] = base_path() . $active_theme->getPath() . "/images/favicons/$component_library/favicon.ico"; | ||
| $link[0]['href'] = file_exists($favicon) ? $favicon : base_path() . $oe_theme_path . "/images/favicons/$component_library/favicon.ico"; |
There was a problem hiding this comment.
file_exists($favicon) will always be FALSE because base_path() returns the path as seen by the web server.
I noticed it when I added a custom favicon.ico to the ewcms_theme
In this case, file_exists checks for /build/profiles/custom/ewcms/themes/ewcms_theme/images/favicons/ec/favicon.ico, and this path does not exist in the filesystem
22Alexandra
force-pushed
the
EWPP-4321
branch
from
f20276f
to
757374e
Compare
intelektron
approved these changes
Sep 5, 2024
nagyad
approved these changes
Sep 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.