ERATRANS-442: Fixed issue that makes sort applied to be overwritten by default bundle sort. #156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y default bundle sort.
upchuk
requested changes
Oct 17, 2022
| @@ -97,7 +97,7 @@ public function executeList(ListPageConfiguration $configuration): ?ListExecutio | |||
| // If we have a specific sort, we use that first, followed by the default | |||
| // bundle sort. Otherwise, just the bundle sort. | |||
| $sort = $sort ? [$sort['name'] => $sort['direction']] : []; | |||
| if ($bundle_sort) { | |||
| if ($bundle_sort && empty($sort)) { | |||
There was a problem hiding this comment.
Thanks for the PR but there are some problems:
- There is no test that proves the issue.
- The fix is not correct. The issue that happens is that the overridden sort (not the bundle one) is for the same field as the default bundle sort, in which case it gets incorrectly overridden by the default bundle sort. If the field used is different, it's fine and it works as expected. Because then you have 2 sorts applied onto the query and that's what needs to happen. So the fix is not exactly correct because like this, if there is a sort override of a different field, the bundle default sort no longer applies as secondary sort. So please fix it so that both get applied if it's for 2 different fields. And add test please.
There was a problem hiding this comment.
Hi, we had an issue with the applied filters and default bundle in EFD.
I've created a PR for that. The case is when both sortings point to the same field, I'm not sure if is the same. I leave it here just in case:
#167
I haven't added tests yet
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ERATRANS-442
Description
Fixed issue that makes sort applied to be overwritten by default bundle sort.
Change log