android-toold-adbd: Fix inconsistency between selinux configurations

[quic-raghuvar]

ConditionPathExists is set to /etc/usb-debugging-enabled as part of meta-oe/recipes-devtools/android-tools/android-tools/android-tools-adbd.service file. However, in meta-oe/dynamic-layers/selinux/recipes-devtool/android-tools/android-tools/android-tools-adbd.service file ConditionPathExists is set to /var/usb-debugging-enabled

This causes an internal inconsistency between selinux-enabled and -disabled configurations.

Hence, change ConditionPathExists=/var/usb-debugging-enabled to ConditionPathExists=/etc/usb-debugging-enabled

Reported-by: @lumag

[quic-raghuvar]

Reported-by: @lumag

[lumag]

Missing DCO tag
Reported-by should also come as a commit message trailer rather than a useless GH commit.

[lumag]

Also rather than c&p original commit text, please explain that this change follows the earlier change and makes two instances of android-toold-adbd.service consistent with each other.

[quic-raghuvar]

@lumag Updated in commit 71d60d2a

[lumag]

Something strange happened with the commits in this PR. Please push a single commit with proper message, tags, etc.

[lumag]

@quic-raghuvar Also Reported-by trailer should use full name and email rather than the GitHub nickname.

[lumag]

@quic-raghuvar Please consult internal Qualcomm documentation on using Git and and on contributing to open-source projects.

[lumag]

@quic-raghuvar any updates? Or was it fire-and-forget request?

[lumag]

@quic-raghuvar so now this PR has 4 commits but 0 changes to the baseline.

[quic-raghuvar]

This seems to have got merged on master. Hence, multiple commits are getting pushed and not able to ammend.

Rectified the commit message in the PR for scarthgap - PR866

[lumag]

@kraj any idea how it got merged, but the PR is not closed? (leaving the question of why it was merged aside).
Unfortunately git log doesn't shows useless data in the 'Commit' field.

[shr-project]

@kraj any idea how it got merged, but the PR is not closed? (leaving the question of why it was merged aside). Unfortunately git log doesn't shows useless data in the 'Commit' field.

github is just read-only mirror of https://git.openembedded.org/meta-openembedded/. So the changes get merged on https://git.openembedded.org/meta-openembedded/ and PRs on github are manually closed after.

The changes are reviewed on openembedded-devel ML (see README) and @kraj accepts the PRs from github as well, but has extra manual work related to it, if you want the reviews to be more efficient than follow the README and use the ML to submit changes and to review them.

[lumag]

@shr-project yep, I'm using emails. @quic-raghuvar isn't (and it results in sad issues with these commits).

BTW: the README has text which can be interpreted as suggesting to send GH pull requests

You are encouraged to fork the mirror on GitHub https://github.com/openembedded/meta-openembedded
to share your patches, this is preferred for patch sets consisting of more than one patch.

I'll propose a change to README. But maybe pull requests should be closed / forbidden here.

[lumag]

@quic-raghuvar As this patch was merged, please close the pull request.