Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Python 3.11 and 3.12 support, drop Django 3.2 #117

Merged
merged 4 commits into from
Apr 17, 2024
Merged
Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,10 @@ name: Python CI

on:
push:
branches: [ master ]
branches: [master]
pull_request:
branches:
- '**'
- '**'
workflow_dispatch:

concurrency:
Expand All @@ -19,8 +19,8 @@ jobs:
fail-fast: false
matrix:
os: [ubuntu-20.04]
python-version: [3.8]
toxenv: [django32, django42, quality, package]
python-version: ['3.8', '3.11']
toxenv: [django42, quality, package]

steps:
- name: checkout repo
Expand Down
2 changes: 1 addition & 1 deletion setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -115,8 +115,8 @@ def package_data(pkg, root_list):
classifiers=[
'Programming Language :: Python',
'Programming Language :: Python :: 3.8',
'Programming Language :: Python :: 3.11',
'Framework :: Django',
'Framework :: Django :: 3.2',
'Framework :: Django :: 4.2',
],
url='https://github.com/openedx/xblock-image-explorer',
Expand Down
17 changes: 8 additions & 9 deletions tox.ini
Original file line number Diff line number Diff line change
@@ -1,30 +1,29 @@
[tox]
envlist = django{32,42},quality,package
envlist = django{42},quality,package

[pytest]
# Use the workbench settings file.
DJANGO_SETTINGS_MODULE = workbench.settings
addopts = --cov-report term-missing --cov-report xml

[testenv]
allowlist_externals =
allowlist_externals =
mkdir
deps =
django32: Django>=3.2,<4.0
deps =
django42: Django>=4.2,<4.3
-r{toxinidir}/requirements/test.txt
commands =
commands =
mkdir -p var
pytest {posargs:tests --cov image_explorer}

[testenv:quality]
commands =
commands =
pylint --fail-under=9.0 image_explorer

[testenv:package]
deps =
deps =
build
twine
commands =
commands =
python -m build
twine check dist/*

Loading