Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update event bus architecture doc to include event_bus_redis #477

Merged
merged 1 commit into from
Jun 2, 2023

Conversation

navinkarkera
Copy link
Contributor

Also update its status to Accepted.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label May 12, 2023
@openedx-webhooks
Copy link

openedx-webhooks commented May 12, 2023

Thanks for the pull request, @navinkarkera! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@navinkarkera navinkarkera force-pushed the navin/update-event-bus-proposal branch from 0e31b6c to 33c1cab Compare May 12, 2023 05:48
Copy link
Contributor

@robrap robrap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Minor proposed fixes/changes.

@navinkarkera navinkarkera force-pushed the navin/update-event-bus-proposal branch from 33c1cab to fa7dd46 Compare May 15, 2023 03:50
@navinkarkera navinkarkera marked this pull request as ready for review May 15, 2023 03:50
@itsjeyd itsjeyd added the needs test run Author's first PR to this repository, awaiting test authorization from Axim label May 16, 2023
@itsjeyd
Copy link

itsjeyd commented May 16, 2023

Thanks for these changes @navinkarkera!

It looks like review is already under way.

We'll need to run tests here next; I labeled the PR accordingly.

@sarina
Copy link
Contributor

sarina commented May 16, 2023

Tests run (btw @robrap you can feel free to run tests as well, when you see they need running)

@itsjeyd itsjeyd removed the needs test run Author's first PR to this repository, awaiting test authorization from Axim label May 23, 2023
@itsjeyd itsjeyd requested a review from robrap May 23, 2023 12:05
@itsjeyd
Copy link

itsjeyd commented May 31, 2023

Hey @robrap, just a friendly reminder that this PR is ready for a second look.

@navinkarkera navinkarkera force-pushed the navin/update-event-bus-proposal branch from fa7dd46 to 7aeabf2 Compare June 1, 2023 09:46
@robrap
Copy link
Contributor

robrap commented Jun 1, 2023

@navinkarkera: Can you merge, or do you need me to? Let me know when you are ready. Also, it would be great to follow the OEP process to announce these updates. Thanks!

@navinkarkera
Copy link
Contributor Author

@robrap I don't have merge rights. Could you please merge and just to confirm, I'll need to create a forum post in https://discuss.openedx.org/c/announcements/17 to announce this update, or am I missing something.

@robrap robrap merged commit 857e988 into openedx:master Jun 2, 2023
@openedx-webhooks
Copy link

@navinkarkera 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@robrap
Copy link
Contributor

robrap commented Jun 2, 2023

@navinkarkera: I'm not sure if the forum post automatically goes to Slack or not, but I'd also use Slack. See #493, which I just created. Also, feel free to update the issue I created if you find that the updates automatically go to Slack, because we could note that in OEP-1.

@navinkarkera
Copy link
Contributor Author

@robrap Have created a forum topic to announce this change but it needs to be approved by a moderator. It seems that these topics are automatically posted on the slack once published, so I'll wait for the approval. If it doesn't automatically post it, I'll do it manually.

@navinkarkera navinkarkera deleted the navin/update-event-bus-proposal branch June 8, 2023 05:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants