feat: THES-105: Payment State Polling #771
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grmartin
force-pushed
the
gmartin/THES-105
branch
from
0a11351
to
f638579
Compare
Payment State polling on Submit Payment and Get Active Order, with a normally non-closeable Dialog.
grmartin
force-pushed
the
gmartin/THES-105
branch
from
f638579
to
d7b42ea
Compare
This spawned REV-3598.
… the Titan backend.
grmartin
commented
Jun 30, 2023
| } catch (error) { | ||
| // We dont quit on error. | ||
| // yield call(handleErrors, error, true); | ||
| yield put(paymentStateDataReceived({ state: PAYMENT_STATE.HTTP_ERROR })); |
There was a problem hiding this comment.
Add common logging for errors from New Relic.
There was a problem hiding this comment.
potentially HTTP errors should fall through, but nothing else.
grmartin
commented
Jun 30, 2023
grmartin
commented
Jun 30, 2023
src/payment/data/sagas.js
Outdated
| // This shouldn't happen. | ||
| // I don't think we need to banner... shouldn't our parent calls recover? (They invoke this) | ||
| keepPolling = false; | ||
| yield put(updatePaymentState.fulfill()); |
grmartin
commented
Jun 30, 2023
grmartin
commented
Jun 30, 2023
pshiu
approved these changes
Jul 3, 2023
|
Splitting exception handling in to another ticket. |
grmartin
added a commit
that referenced
this pull request
May 15, 2024
* feat: THES-105: Payment State Polling Payment State polling on Submit Payment and Get Active Order, with a normally non-closeable Dialog. * fix: Advisories permitted for the moment This spawned REV-3598. * fix: Removal of `PAYMENT_STATE.PROCESSING`, this state is internal to the Titan backend. * fix: Changes from PR Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Payment State polling on Submit Payment and Get Active Order, with a normally non-closeable Dialog.
This spawned REV-3598.