Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add stripe 3DS to checkout page(WIP) #710

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

wdrussell2015
Copy link
Contributor

@wdrussell2015 wdrussell2015 commented Feb 21, 2023

REV-3241
This PR updates the checkout flow to respond to an 'action required' response from ecommerce. It will redirect the user to perform an external authentication and then return to the url specified in ecommerce/extensions/payment/processors/stripe.py

Note:

  • This will NOT be merged/deployed before the updates to ecommerce for implementing webhooks are made and the work in REV-3187 is complete
  • This was developed using branch: julianajlk/REV-3240/three-d-secure
  • Currently the payment will complete on Stripe end but is not updated in ecommerce
  • tested with cards from stripe docs

Screenshot of 3DS page:
Screenshot 2023-02-21 at 2 12 10 PM

@wdrussell2015 wdrussell2015 requested a review from a team as a code owner February 21, 2023 19:14
@pshiu
Copy link
Contributor

pshiu commented Feb 21, 2023

Can we add tests to stripe/service.test.js for the new handleServerResponse()?

Copy link
Contributor

@grmartin grmartin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :) https://media.giphy.com/media/NytMLKyiaIh6VH9SPm/giphy.gif

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants