Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add package-lock file version check #600

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

edx-requirements-bot
Copy link
Contributor

lockfileVersion for the package-lock.json generated by NPM6 was 1 but now as we've moved to Node16 and NPM8, package-lock.json should be generated using NPM8. lockfileVersion for package-lock.json generated using NPM8 is 2. So here we're going to check the lockfileVersion in package-lock.json

Additional information from script execution

Python code cleanup by the cleanup-python-code Jenkins job.

This pull request was generated by the cleanup-python-code Jenkins job, which ran
cd .github/workflows;
printf "#check package-lock file version\n\nname: Lockfile Version check\n\non:\n  push:\n    branches:\n    - master\n  pull_request:\n\njobs:\n  version-check:\n    uses: edx/.github/.github/workflows/lockfileversion-check.yml@master\n" >> lockfileversion-check.yml;

The following packages were installed:
``

Deleted obsolete pull_requests:
#599

@aht007
Copy link
Member

aht007 commented May 6, 2022

CI already failing on Master branch

@awais786 awais786 requested a review from pshiu May 25, 2022 10:45
@UsamaSadiq
Copy link
Member

Arbi-bom doesn't have access to update this branch so created a new PR #649 from a fork.

@UsamaSadiq
Copy link
Member

@pshiu could you please close this PR and review the new PR once again. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants