fix: Removal of PAYMENT_STATE.PROCESSING, this state is internal to…

… the Titan backend.
openedx · Jun 29, 2023 · bdd666e · bdd666e
1 parent e3f4f48
commit bdd666e
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 11 deletions.
diff --git a/src/payment/PaymentProcessingModal.test.jsx b/src/payment/PaymentProcessingModal.test.jsx
@@ -39,7 +39,7 @@ const basketStoreGenerator = (paymentState = PAYMENT_STATE.DEFAULT, keepPolling
   }
 );
 
-const shouldPoll = (payState) => payState === PAYMENT_STATE.PENDING || payState === PAYMENT_STATE.PROCESSING;
+const shouldPoll = (payState) => payState === PAYMENT_STATE.PENDING;
 
 const buildDescription = (tp) => `is ${shouldPoll(tp.status) ? '' : 'NOT '}shown (status == '${tp.status}')`;
 
@@ -80,7 +80,6 @@ describe('<PaymentProcessingModal />', () => {
 
   /* eslint-disable no-multi-spaces */
   const tests = [
-    { expect: true,  status: PAYMENT_STATE.PROCESSING },
     { expect: true,  status: PAYMENT_STATE.PENDING    },
     { expect: false, status: PAYMENT_STATE.FAILED     },
     { expect: false, status: PAYMENT_STATE.DEFAULT    },

diff --git a/src/payment/data/constants.js b/src/payment/data/constants.js
@@ -34,10 +34,6 @@ export const PAYMENT_STATE = (((webserviceEnum = {
    * Payment is Pending
    */
   PENDING: 'pending',
-  /**
-   * Async Processing of payment is ongoing.
-   */
-  PROCESSING: 'processing',
 }) => ({
   ...webserviceEnum,
 
@@ -64,6 +60,6 @@ export const PAYMENT_STATE = (((webserviceEnum = {
  * @see PAYMENT_STATE
  */
 export const POLLING_PAYMENT_STATES = [
-  PAYMENT_STATE.PROCESSING,
+  PAYMENT_STATE.PENDING,
   PAYMENT_STATE.HTTP_ERROR,
 ];
diff --git a/src/payment/data/redux.test.js b/src/payment/data/redux.test.js
@@ -241,7 +241,7 @@ describe('redux tests', () => {
                   {
                     basket: {
                       foo: 'bar',
-                      paymentState: PAYMENT_STATE.PROCESSING,
+                      paymentState: PAYMENT_STATE.PENDING,
                       basketId: 7,
                       payments: [
                         { paymentNumber: 7 },
@@ -254,15 +254,15 @@ describe('redux tests', () => {
 
         triggerStore.dispatch(updatePaymentState());
         expect(triggerStore.getState().payment.basket.paymentStatePolling.keepPolling).toBe(true);
-        expect(triggerStore.getState().payment.basket.paymentState).toBe(PAYMENT_STATE.PROCESSING);
+        expect(triggerStore.getState().payment.basket.paymentState).toBe(PAYMENT_STATE.PENDING);
 
         triggerStore.dispatch({ type: PAYMENT_STATE_DATA_RECEIVED, payload: { state: PAYMENT_STATE.COMPLETED } });
         expect(triggerStore.getState().payment.basket.paymentStatePolling.keepPolling).toBe(false);
         expect(triggerStore.getState().payment.basket.paymentState).toBe(PAYMENT_STATE.COMPLETED);
 
         triggerStore.dispatch(updatePaymentState.fulfill());
         expect(triggerStore.getState().payment.basket.paymentStatePolling.keepPolling).toBe(false);
-        expect(triggerStore.getState().payment.basket.paymentState === PAYMENT_STATE.PROCESSING).toBe(false);
+        expect(triggerStore.getState().payment.basket.paymentState === PAYMENT_STATE.PENDING).toBe(false);
       });
     });
   });

diff --git a/src/payment/data/sagas.test.js b/src/payment/data/sagas.test.js
@@ -682,7 +682,7 @@ describe('saga tests', () => {
                 payment: {
                   basket: {
                     foo: 'bar',
-                    paymentState: PAYMENT_STATE.PROCESSING,
+                    paymentState: PAYMENT_STATE.PENDING,
                     basketId: 7,
                     payments: [
                       { paymentNumber: 7 },