-
Notifications
You must be signed in to change notification settings - Fork 201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Untranslatable strings #1193 #1449
base: master
Are you sure you want to change the base?
Conversation
Thanks for the pull request, @jciasenza! What's next?Please work through the following steps to get your changes ready for engineering review: 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. 🔘 Let us know that your PR is ready for review:Who will review my changes?This repository is currently maintained by Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:
When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
@jciasenza Thank you for this contribution! @openedx/committers-frontend-app-learning Could you please kick off a build for these changes? |
@@ -123,4 +126,4 @@ InstructorToolbar.defaultProps = { | |||
tab: '', | |||
}; | |||
|
|||
export default InstructorToolbar; | |||
export default injectIntl(InstructorToolbar); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you use useIntl
instead of injectIntl
? Or would that require a lot of test refactoring?
@@ -120,7 +120,7 @@ class MasqueradeWidget extends Component { | |||
return ( | |||
<div className="flex-grow-1"> | |||
<div className="row"> | |||
<span className="col-auto col-form-label pl-3">View this course as:</span> | |||
<span className="col-auto col-form-label pl-3">{this.props.intl.formatMessage(messages.titleViewCourseIn)}</span> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: prefer the component form in a JSX context like this:
<span className="col-auto col-form-label pl-3">{this.props.intl.formatMessage(messages.titleViewCourseIn)}</span> | |
<span className="col-auto col-form-label pl-3"><FormattedMessage {...messages.titleViewCourseIn} /></span> |
Fix: Untranslatable strings
Fixes #1193
What changed?
Add message ids and add a file
src/instructor-toolbar/messages.js
Also modify the masquerade
src/instructor-toolbar/masquerade-widget/MasqueradeWidget.jsx
If you approve my changes I will push them,
or if something needs to be modified let me know thanks !!!
Atte
Juan Carlos (Aulasneo)
Developer Checklist
Test suites passing
Documentation and test plan updated, if applicable
Received code-owner approving review
[ How should a reviewer test this PR? ]
Reviewer Checklist
Collectively, these should be completed by reviewers of this PR:
I've done a visual code review
FYI: @openedx/content-aurora