chore: Update to the new version of brand-openedx in the new scope. #1216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Part of openedx/axim-engineering#23 This updates the `@edx/brand` alias to point to the `brand-openedx` package at the `openedx` scope. This does not impact imports because this package is used via an alias.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1216 +/- ##
==========================================
+ Coverage 88.09% 88.14% +0.04%
==========================================
Files 268 268
Lines 4537 4537
Branches 1145 1145
==========================================
+ Hits 3997 3999 +2
+ Misses 526 524 -2
Partials 14 14 ☔ View full report in Codecov by Sentry. |
brian-smith-tcril
approved these changes
Oct 20, 2023
Comment on lines
+3490
to
+3495
| "node_modules/@edx/frontend-lib-learning-assistant/node_modules/@edx/brand": { | ||
| "name": "@edx/brand-openedx", | ||
| "version": "1.2.0", | ||
| "resolved": "https://registry.npmjs.org/@edx/brand-openedx/-/brand-openedx-1.2.0.tgz", | ||
| "integrity": "sha512-r4PDN3rCgDsLovW44ayxoNNHgG5I4Rvss6MG5CrQEX4oW8YhQVEod+jJtwR5vi0mFLN2GIaMlDpd7iIy03VqXg==" | ||
| }, |
There was a problem hiding this comment.
I was hoping we could avoid this by getting the scope change into frontend-lib-learning-assistant but as soon as I made a PR there I failed the edx CLA check. I guess we'll just have to live with mismatched deps for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of openedx/axim-engineering#23
This updates the
@edx/brandalias to point to thebrand-openedxpackage atthe
openedxscope. This does not impact imports because this package is usedvia an alias.