Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: adding more performance tweaks and logging #623

Merged
merged 1 commit into from
Jun 23, 2023
Merged

feat: adding more performance tweaks and logging #623

merged 1 commit into from
Jun 23, 2023

Conversation

johnnagro
Copy link
Contributor

Description

iloveagent57
iloveagent57 approved these changes Jun 23, 2023
View reviewed changes
Copy link
Contributor

@iloveagent57 iloveagent57 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved! spelling!

enterprise_catalog/apps/api_client/discovery.py Outdated
@@ -38,9 +40,12 @@ def _retrieve_metadata_for_content_filter(self, content_filter, page, request_pa
DISCOVERY_SEARCH_ALL_ENDPOINT,
json=content_filter,
params=request_params,
timeout=self.HTTP_TIMEOUT,
)
elabsed_seconds = response.elapsed.total_seconds()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"elabsed"

enterprise_catalog/apps/api_client/discovery.py Outdated
LOGGER.info(f'Retrieved results from course-discovery for page {page} in {elabsed_seconds} seconds.')
LOGGER.info(
f'Retrieved results from course-discovery for page {page} in '
f'retrieve_metadata_for_content_filter_seconds={elabsed_seconds} seconds.')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"elabsed"

@johnnagro johnnagro merged commit 40c912c into master Jun 23, 2023
6 checks passed
@johnnagro johnnagro deleted the johnnagro/ENT-7253/1 branch June 23, 2023 13:52
irfanuddinahmad pushed a commit that referenced this pull request Jul 24, 2024
@johnnagro
feat: adding more performance tweaks and logging (#623)
66e4ce7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iloveagent57 iloveagent57 iloveagent57 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@johnnagro @iloveagent57