fix: connect verify_student handlers to app #35561
Merged
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alangsto
force-pushed
the
alangsto/fix_verify_student_handlers
branch
from
5f7d79e
to
fd55bda
Compare
ilee2u
reviewed
Sep 30, 2024
Comment on lines
20
to
21
| from lms.djangoapps.verify_student.signals import signals # pylint: disable=unused-import | ||
| from lms.djangoapps.verify_student.signals import handlers # pylint: disable=unused-import |
There was a problem hiding this comment.
NIT: Can these import statements be combined, sorta like this?
from lms.djangoapps.verify_student.signals import handlers, signals # pylint: disable=unused-import
ilee2u
approved these changes
Sep 30, 2024
alangsto
force-pushed
the
alangsto/fix_verify_student_handlers
branch
from
3c6c74a
to
3b17720
Compare
|
2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production. |
|
2U Release Notice: This PR has been deployed to the edX production environment. |
1 similar comment
|
2U Release Notice: This PR has been deployed to the edX production environment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The signal handlers were refactored as part of #35468, but never re-imported to the
apps.pyfile. This means that the handlers have not been connected since that PR has been merged. This PR reconnects the handlers to the app.