Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat! Dropping Sass support from builtin video block #35506

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

farhan
Copy link
Contributor

@farhan farhan commented Sep 19, 2024

Dropping Sass support from builtin video block

Tickets: #35570

Tasks:

  • Convert Sass variable into css variables

  • Compile the css files of the block following below steps.

    • Change this line to the following to avoid adding comments in the compiled css files
           source_comments: int = SASS_COMMENTS_NONE
    • Compile the sass to uncompressed CSS using following command
            npm run compile-sass-dev
    • Copy the compiled XBlock linked CSS (lms/static/css/*Display.css and lms/static/css/*Editor.css) into xmodule/static/css-builtin-blocks.
    • Format the CSS files using the editor.
    • Add those CSS files to version control.
  • Replace add_sass_to_fragment to add_css_to_fragment in blocksin .py file

  • Remove all .scss files linked to the block under xmodule/assets.

    • Make sure to remove the .scss file in a separate alone commit so reviewer could review scss changes and they stay in history.
    • Don't remove the scss file if its linked to some other block.

Testing:

  • Run npm run build to run webpack and compile sass files.
  • Run ./manage.py lms collectstatic in lms shell to re-collect static files.
  • Run ./manage.py cms collectstatic in cms shell to re-collect static files.
  • Verify the block's compiled css and the css global variables in the LMS
  • Verify the block's compiled css and the css global variables in the Studio
  • Test the XBlock rendering and User Experience in LMS
  • Test the XBlock rendering and User Experience in Studio
Screenshots
Screenshot 2024-10-01 at 5 50 29 PM
Screenshot 2024-10-01 at 5 50 19 PM
lms
cms

@farhan farhan force-pushed the farhan/sass-to-css-video-block branch 3 times, most recently from bd41dcd to a509763 Compare September 21, 2024 12:16
@farhan farhan changed the title Dropping Sass support from builtin video block feat! Dropping Sass support from builtin video block Sep 23, 2024
@farhan farhan self-assigned this Sep 23, 2024
@farhan farhan marked this pull request as ready for review September 23, 2024 09:13
@farhan farhan force-pushed the farhan/sass-to-css-video-block branch 3 times, most recently from 72a51ec to e4e5992 Compare October 1, 2024 11:58
@farhan farhan requested a review from nsprenkle October 1, 2024 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant