feat! Dropping Sass support from builtin video block #35506
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dropping Sass support from builtin video block
Tickets: #35570
Tasks:
Convert Sass variable into css variables
Compile the css files of the block following below steps.
xmodule/static/css-builtin-blocks
.Replace
add_sass_to_fragment
toadd_css_to_fragment in blocks
in.py
fileRemove all .scss files linked to the block under xmodule/assets.
Testing:
npm run build
to run webpack and compile sass files../manage.py lms collectstatic
in lms shell to re-collect static files../manage.py cms collectstatic
in cms shell to re-collect static files.