WIP Fixed calculation of max_pts for problems which are not attempted yet

[amir-qayyum-khan]

Background

connected to mitocw#190

• In existing code while calculating grades if your did not attempt problem then courseware set his grades like graded_total = Score(0.0, 1.0, True, section_name, None)
  https://github.com/edx/edx-platform/blob/master/lms/djangoapps/courseware/grades.py#L461
• This case an issue when we show non-normalize data on legacy dashboard. In this case the grades of students appear like score/max-score and for students who did not attempted the same problem the score will be 0/1.
• 0/1 looks like normalize grade, and whole grade sheet look like mixture of normalize and non-normalize grades.

What is done in this PR

Studio Updates: None
LMS Updates:

• Now grades of problems which are not attempted will be 0/max score.

cc @pdpinch @pwilkins
@pdpinch as we discussed yesterday. you told me to create Pr for ormsbee. So that you can discuss with him.

After solution:

• Not Normalize
  
• Normalize
  

[openedx-webhooks]

Thanks for the pull request, @amir-qayyum-khan! I've created OSPR-1128 to keep track of it in JIRA. JIRA is a place for product owners to prioritize feature reviews by the engineering development teams.

Feel free to add as much of the following information to the ticket:

• supporting documentation
• edx-code email threads
• timeline information ("this must be merged by XX date", and why that is)
• partner information ("this is a course on edx.org")
• any other information that can help Product understand the context for the PR

All technical communication about the code itself will still be done via the GitHub pull request interface. As a reminder, our process documentation is here.

If you like, you can add yourself to the AUTHORS file for this repo, though that isn't required. Please see the CONTRIBUTING file for more information.

[amir-qayyum-khan]

jenkins run python
jenkins run bokchoy

[pdpinch]

@amir if you're still available, can you update the description with the changes I made on the mitocw fork? I think the intent is clearer from what I wrote.

[amir-qayyum-khan]

if i am not wrong, both looks same to me. Can you verify please?

mitocw#196 (comment)
On 04-Feb-2016 11:12 pm, "Peter Pinch" [email protected] wrote:

@amir https://github.com/amir if you're still available, can you update
the description with the changes I made on the mitocw fork? I think the
intent is clearer from what I wrote.

—
Reply to this email directly or view it on GitHub
https://github.com/edx/edx-platform/pull/11425#issuecomment-179974726.

[pdpinch]

@amir-qayyum-khan I was looking for a PR that just addressed the grade calculation issue, without including the legacy dashboard changes. I wanted to have a focused diff to discuss with Dave.

I'll try to talk to Dave about it today anyway, so don't change anything until you hear from me.

[nedbat]

@amir-qayyum-khan is this ready to be reviewed? We use "WIP" to mean the author isn't done writing it yet.

[pdpinch]

That's our meaning too. This is not ready to be reviewed.

I expect Dave Ormsbee is going to have some advice for us.

[pdpinch]

Dave has recommended another direction.