Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: update actions #471

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from
Draft

ci: update actions #471

wants to merge 5 commits into from

Conversation

CodeWithEmad
Copy link
Member

@CodeWithEmad CodeWithEmad commented Jul 21, 2024 •
edited
Loading

This will update all the actions as follows:

  • os: ubuntu-22.04
  • checkout: v4
  • setup-python: v5
  • python: 3.12

Close #460

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Jul 21, 2024
@openedx-webhooks
Copy link

Thanks for the pull request, @CodeWithEmad!

What's next?

Please work through the following steps to get your changes ready for engineering review:

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

🔘 Update the status of your PR

Your PR is currently marked as a draft. After completing the steps above, update its status by clicking "Ready for Review", or removing "WIP" from the title, as appropriate.

🔘 Let us know that your PR is ready for review:

Who will review my changes?

This repository is currently unmaintained.

To get help with finding a technical reviewer, tag the community contributions project manager for this PR in a comment and let them know that your changes are ready for review:

  1. On the right-hand side of the PR, find the Contributions project, click the caret in the top right corner to expand it, and check the "Primary PM" field for the name of your PM.
  2. Find their GitHub handle here.

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@itsjeyd
Copy link

itsjeyd commented Jul 25, 2024

Hey @CodeWithEmad, thank you for this contribution!

Let us know when it's ready for review.

@CodeWithEmad
Copy link
Member Author

For sure, @itsjeyd.
I will worl on it in the coming days. In the meanwhile, I wanted to ask about the current state of tests. Should we have the CI actions run only on Python 3.12 or we have to have 3.8 also?

@itsjeyd
Copy link

itsjeyd commented Jul 26, 2024

@CodeWithEmad Sounds good!

In the meanwhile, I wanted to ask about the current state of tests. Should we have the CI actions run only on Python 3.12 or we have to have 3.8 also?

I'll forward this question to @feanil.

@feanil
Copy link
Contributor

feanil commented Jul 31, 2024

We should continue to run the testing with both Python 3.11 and 3.12 but dropping 3.8 is totally fine across all openedx projects.

@CodeWithEmad
fix: Update workflow_dispatch trigger
3d5b9d3 
Remove unnecessary branch specification for workflow_dispatch event
@CodeWithEmad
fix: xblockutils is deprecated
9e4ac98 
All of the functionalities in xblockutils is moved to xblock.utils inside XBlock pakcage
@CodeWithEmad
fix: remove pkg_resources for python 3.12 compatibility
b8f761c 
pkg_resources is available in python 3.12 only if setuptools is explicitly installed, which is not always the case. We fix that by replacing all usage of pkg_resources with importlib_resources.
@CodeWithEmad
feat: new make commands to interact with dev container
36cacf4 
* dev.stop: Stop the running container
* dev.migrate: Run migrations in the container
* dev.logs: View logs from the container
* dev.exec: Execute to the dev container
@CodeWithEmad
fix: Support for python 3.8 dropped
9e0156e
@CodeWithEmad
Copy link
Member Author

@feanil I'm working on dropping Python 3.8 here, but there are a couple of blockers here:
the dev image is using the xblock-sdk image,

edx-cookiecutters/cookiecutter-xblock/{{cookiecutter.repo_name}}/Dockerfile

Line 2 in 46948ba

FROM openedx/xblock-sdk

which is still using Python 3.8, https://github.com/openedx/xblock-sdk/blob/1760448ebb073edba35be87d99f474d90d9421ac/Dockerfile#L19
I found this openedx/xblock-sdk#350, but it's stuck for a while.
Also, lint jobs are failing since there's no pkg_resources and edx-lint is still using it: openedx/edx-lint#398

https://github.com/openedx/edx-cookiecutters/actions/runs/10206678813/job/28240034237?pr=471

@feanil
Copy link
Contributor

feanil commented Aug 6, 2024

@CodeWithEmad I'll see if we can land the xblock-sdk issue first then we can update that as a part of the PR here.

@farhan
Copy link

farhan commented Aug 29, 2024

Issue will be fixed in openedx/xblock-sdk#397
Hopefully this PR will be unblocked to work on once its merged and docker image pushed.
FYI: @CodeWithEmad

@CodeWithEmad
Copy link
Member Author

Thanks, @farhan. I'll continue this in the coming weeks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Contributions
Status: Waiting on Author
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update edx-cookie-cutter
5 participants
@CodeWithEmad @openedx-webhooks @itsjeyd @feanil @farhan