-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DRAFT: docs: Initial Migration Attempt from Legacy OLX docs. Still Erroring #552
base: main
Are you sure you want to change the base?
Conversation
Thanks for the pull request, @jswope00! What's next?Please work through the following steps to get your changes ready for engineering review: 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. 🔘 Let us know that your PR is ready for review:Who will review my changes?This repository is currently maintained by Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:
When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
ha, I spent too long not looking at this and now the build is passed... ?!?!? .... do you want a review? |
@sarina Yes, I've been able to fix all the build errors. Just a general check of whether this migration of OLX from legacy to the new Open edX docs and placed in the sidebar works for you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume this is just a direct port, but one could imagine doing a find/replace "edX" -> "Open edX".
There might be a way of injecting a mini banner atop each of these pages with some warning like, "the contennt of these pages may be out of date" and even a request for help. Food for thought. Happy to play around with it once this is merged.
@@ -185,3 +185,4 @@ Open edX Documentation | |||
other/feedback | |||
other/getting_help | |||
Documentation Decisions <documentors/decisions/index> | |||
olx/index |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm fine with this placement, but I think another place more discoverable to educators would be Educators > References
Merge when you're satisfied with your work & have addressed the conflict |
A draft pull request to determine what errors are thrown in the build process on Github. It is not ready for a merge yet.