Skip to content
This repository has been archived by the owner on Aug 1, 2024. It is now read-only.

feat: Updated devstack mysql 5.7 to 8 #1094

Draft
wants to merge 8 commits into
base: master
Choose a base branch
from
Draft

Conversation

farhanumar
Copy link
Contributor

Updated mysql 5.7 to mysql 8 for new dev stack setup


I've completed each of the following or determined they are not applicable:

  • Made a plan to communicate any major developer interface changes (or N/A)

@@ -28,6 +28,9 @@ done
# Run edxapp migrations first since they are needed for the service users and OAuth clients
# docker-compose exec -T lms bash -e -c 'source /edx/app/edxapp/edxapp_env && cd /edx/app/edxapp/edx-platform && paver update_db --settings devstack_docker'

echo -e "Change MySQL Host to mysql80"
docker-compose exec -T lms bash -e -c 'find /edx/ -type f -exec sed -i 's/mysql57/mysql80/g' {} +'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this quoting scheme looks wrong. Do we want single-quotes for the sed command?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also more generally why are we attempting to find-and-replace here at provision-time rather than in source code?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@matthugs This was just to verify that provisioning test work. This PR will not merge. That was work around to verify that images need updates for mysql hosts for the provisioning test to pass. The last commit in this PR passed the tests.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants