Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix readme typo #329

Merged
merged 1 commit into from
Sep 17, 2024
Merged

fix readme typo #329

merged 1 commit into from
Sep 17, 2024

Conversation

runzhliu
Copy link

@runzhliu runzhliu commented Sep 12, 2024

fix a few typos

Pull Request template

Please, go through these steps before you submit a PR.

Why is this PR required? What issue does it fix?:

fix a few typos

What this PR does?:

fix a few typos

Does this PR require any upgrade changes?:

No

If the changes in this PR are manually verified, list down the scenarios covered::

Any additional information for your reviewer? :
Mention if this PR is part of any design or a continuation of previous PRs

Checklist:

  • Fixes #
  • PR Title follows the convention of <type>(<scope>): <subject>
  • Has the change log section been updated?
  • Commit has unit tests
  • Commit has integration tests
  • (Optional) Are upgrade changes included in this PR? If not, mention the issue/PR to track:
  • (Optional) If documentation changes are required, which issue on https://github.com/openebs/openebs-docs is used to track them:

@tiagolobocastro
Copy link

thanks @runzhliu
As additional step would you mind signing your git commit ?

@runzhliu
Copy link
Author

thanks @runzhliu As additional step would you mind signing your git commit ?

sure ;)

@dsharma-dc
Copy link
Contributor

dsharma-dc commented Sep 12, 2024

This PR is a duplicate of #327

Copy link
Member

@avishnu avishnu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR !!

Signed-off-by: runzhliu <[email protected]>
@avishnu avishnu merged commit 00608dc into openebs:develop Sep 17, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants