Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(NodeController): made node polling interval configurable #256

Merged

Conversation

omric-runai
Copy link
Contributor

@omric-runai omric-runai commented Sep 3, 2023

Why is this PR required? What issue does it fix?:
This PR makes the polling interval of the node configurable, allowing users to get a higher update rate for their csistoragecapacities, and preventing scheduling issue.

What this PR does?:
This PR adds a new flag, --node-polling-interval, with a default value of 60s (same as the currant hard-coded value), which controls the polling rate of the node.

Does this PR require any upgrade changes?:
No.

If the changes in this PR are manually verified, list down the scenarios covered::

  1. Verified that the default remains 60s, when not using the flag.
  2. Verified that changing the value of the flag changes the polling rate.

Any additional information for your reviewer? :
N/A

Checklist:

@abhilashshetty04
Copy link
Contributor

Hi @omric-runai , Thanks for the PR. lgtm

Copy link
Member

@Abhinandan-Purkait Abhinandan-Purkait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@avishnu @abhilashshetty04 Since this is configurable, I think we need a helm value and template change to accommodate this?

pkg/driver/agent.go Outdated Show resolved Hide resolved
@avishnu
Copy link
Member

avishnu commented Sep 7, 2023

@avishnu @abhilashshetty04 Since this is configurable, I think we need a helm value and template change to accommodate this?

Yes, we need a configurable parameter in the helm values.yaml

@Abhinandan-Purkait
Copy link
Member

@omric-runai Thanks for the PR. Would you be interested in raising a helm chart change for allowing configuring this from Helm Chart? You can raise a separate PR for that if you want.

@Abhinandan-Purkait Abhinandan-Purkait merged commit 45ebdf6 into openebs:develop Sep 8, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow configurable polling interval in NodeController
4 participants