fix: refactor: BouquetDetailView dataset description #311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for meteo-france ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for ecospheres ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
abulte
force-pushed
the
fix/bouquet-detail-desc
branch
from
7f24815
to
4daef4e
Compare
Jorek57
approved these changes
Jan 4, 2024
abulte
force-pushed
the
fix/bouquet-detail-desc
branch
from
4daef4e
to
570b38a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #307
Le fix est là 471d72a.
Le reste consiste à refactorer le composant en TS, et les stores associés, pour que le linting ait pu permettre de détecter cette erreur (
descriptionn'est pas dans le typeDatasetProperties) 4daef4e.Le refactor aggrave la dépendance Bouquet/Ecosphères soulevée dans #294 pour scoper un peu cette PR et ne pas partir dans un refacto des types ou de la gestion des univers. La vue est de toute façon dans
custom.Related #309 (getting there, page after page)