Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

grpc_server: use x-correlation-id as request-id when possible #128

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dtrifiro
Copy link
Contributor

@dtrifiro dtrifiro commented Sep 16, 2024

Currently, the vLLM OpenTelemetry span exports the request_id, but inspecting the WatsonX trace in Instana can be confusing due to the presence of multiple IDs.
Using the x-correlation-id as the request_id would help make the trace more coherent.

https://issues.redhat.com/browse/RHOAIENG-12927

@codecov-commenter
Copy link

codecov-commenter commented Sep 16, 2024

Codecov Report

Attention: Patch coverage is 90.90909% with 2 lines in your changes missing coverage. Please review.

Project coverage is 56.10%. Comparing base (20db20b) to head (72743ad).

Files with missing lines Patch % Lines
src/vllm_tgis_adapter/grpc/grpc_server.py 75.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #128      +/-   ##
==========================================
+ Coverage   55.64%   56.10%   +0.45%     
==========================================
  Files          24       24              
  Lines        1488     1508      +20     
  Branches      269      271       +2     
==========================================
+ Hits          828      846      +18     
- Misses        583      584       +1     
- Partials       77       78       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants