Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RHOAIENG-1107] Storage Class Filter #3235

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jpuzz0
Copy link
Contributor

@jpuzz0 jpuzz0 commented Sep 20, 2024

https://issues.redhat.com/browse/RHOAIENG-1107

Description

Added filter toolbar and pagination to the storage classes table page. Users can filter by display name and/or Openshift class name.

image image image

Demo:
https://github.com/user-attachments/assets/6d86fe29-a3c8-46f1-badc-e459dce17123

(cc @xianli123)

How Has This Been Tested?

  1. With the feature flag enabled, visit the storage class table's page; /storageClasses?devFeatureFlags=disableStorageClasses
  2. Verify pagination exists
  3. Verify the toolbar filter exists and matches the design
  4. Verify you can filter by both display name and openshift class name
  5. Verify empty state when filter yields no results and can reset filters via the action in that empty state ("Clear filters")

Test Impact

Added catch-all filter cypress test for storage classes

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change.

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

Copy link
Contributor

openshift-ci bot commented Sep 20, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign manosnoam for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant