Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update runtime's python packages #706

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

atheo89
Copy link
Member

@atheo89 atheo89 commented Sep 20, 2024

Related to: https://issues.redhat.com/browse/RHOAIENG-13121

Description

How Has This Been Tested?

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

Copy link
Contributor

openshift-ci bot commented Sep 20, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from atheo89. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@@ -1,24 +1,24 @@
# Copied from: https://github.com/elyra-ai/elyra/blob/main/etc/generic/requirements-elyra.txt

# This is a comprehensive list of python dependencies that Elyra requires to execute Jupyter notebooks.
ipykernel==6.13.0
ipython==8.10.0
ipykernel==6.29.5
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@harshad16 I've manually updated this file to the latest versions, and I've applied the same versions to the Pipfiles example as well.

The packages on the requirments.txt on elyra repo looks old: https://github.com/elyra-ai/elyra/blob/main/etc/generic/requirements-elyra.txt

Since I wasn't certain which versions to use, I opted to go with the latest updates.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Personally I would remove any changes to these requirements-elyra.txt files from this PR. Or delete them completely to comply with: https://issues.redhat.com/browse/RHOAIENG-11068.

Copy link
Contributor

openshift-ci bot commented Sep 20, 2024

@atheo89: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/runtimes-ubi9-e2e-tests 391b967 link true /test runtimes-ubi9-e2e-tests
ci/prow/rocm-runtimes-ubi9-e2e-tests 391b967 link true /test rocm-runtimes-ubi9-e2e-tests
ci/prow/images 391b967 link true /test images

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants