Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin kfp to the latest 2.9.0 release. #702

Merged
merged 1 commit into from
Sep 19, 2024
Merged

Conversation

jstourac
Copy link
Member

@jstourac jstourac commented Sep 19, 2024

Partially fixes: https://issues.redhat.com/browse/RHOAIENG-11623

And the needs for the onnxconverter-common to be pinned to 1.13.0 release, see [1].
[1] https://issues.redhat.com/browse/RHOAIENG-11623?focusedId=25612155&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-25612155

Description

How Has This Been Tested?

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

Copy link
Member

@harshad16 harshad16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

thanks 💯

Copy link
Contributor

openshift-ci bot commented Sep 19, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: harshad16

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jiridanek
Copy link
Member

jiridanek commented Sep 19, 2024

Maybe mention issue number in commit summary? (RHOAIENG-11623) Otherwise looks good at first glance

/lgtm

@jiridanek
Copy link
Member

/hold

for now, it got approved somehow and I'm not sure we really mean it

@harshad16
Copy link
Member

Merging this to so other work can be rebase #701

@jiridanek
Copy link
Member

/unhold

nvr mind, we do

@harshad16 harshad16 merged commit 1600f89 into opendatahub-io:main Sep 19, 2024
9 of 19 checks passed
@harshad16
Copy link
Member

/hold

for now, it got approved somehow and I'm not sure we really mean it

we did mean it , we needed this change, so elyra folks can work in their pace.
thank you for effectively , gate checking this kinda request.
i have also updated the description a bit.

@jstourac jstourac deleted the kfpPin branch September 19, 2024 12:37
@atheo89
Copy link
Member

atheo89 commented Sep 19, 2024

Thanks @jstourac ! Is it intentional that we didn't apply this to TensorFlow images?

@harshad16
Copy link
Member

Thanks @jstourac ! Is it intentional that we didn't apply this to TensorFlow images?

yes, we can't pin it to new version
do to this: https://issues.redhat.com/browse/RHOAIENG-6486

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants