-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pin kfp to the latest 2.9.0 release. #702
Conversation
This needs the onnxconverter-common to be pinned to 1.13.0 release, see [1]. [1] https://issues.redhat.com/browse/RHOAIENG-11623?focusedId=25612155&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-25612155
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
thanks 💯
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: harshad16 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Maybe mention issue number in commit summary? (RHOAIENG-11623) Otherwise looks good at first glance /lgtm |
/hold for now, it got approved somehow and I'm not sure we really mean it |
Merging this to so other work can be rebase #701 |
/unhold nvr mind, we do |
we did mean it , we needed this change, so elyra folks can work in their pace. |
Thanks @jstourac ! Is it intentional that we didn't apply this to TensorFlow images? |
yes, we can't pin it to new version |
Partially fixes: https://issues.redhat.com/browse/RHOAIENG-11623
And the needs for the onnxconverter-common to be pinned to 1.13.0 release, see [1].
[1] https://issues.redhat.com/browse/RHOAIENG-11623?focusedId=25612155&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-25612155
Description
How Has This Been Tested?
Merge criteria: