Generalise eo3-compatible product handling in materialised view definition #996
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robbibt
approved these changes
Mar 12, 2024
There was a problem hiding this comment.
Hi @SpacemanPaul, looks great to me - this should catch our Intertidal metadata type (named "eo3_intertidal").
matt-fry-ga
approved these changes
Mar 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The space materialised view definition previously required all supported metadata types to be explicitly included in the view definition. A catch-all has been added for all metadata types starting with
eo3_.Note that a non-eo3-compatible metadata type with a name starting with
eo3_will now break OWS, but this is better than any metadata type with a name not in a whitelist breaking OWS.Also fixes a bug in WMTS - exposed by more thorough WMTS validation in newer versions of OWSLib. (Dimension sections in Capabilities documents did contain a
Defaultsection, which is required by the standard.📚 Documentation preview 📚: https://datacube-ows--996.org.readthedocs.build/en/996/