Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dockerfile: update to GDAL 3.9.1 #1046

Merged
merged 1 commit into from
Aug 8, 2024

Conversation

pjonsson
Copy link
Contributor

@pjonsson pjonsson commented Aug 6, 2024

Make the minimal change to mirror
the change from datacube-explorer's
update to GDAL 3.9.


📚 Documentation preview 📚: https://datacube-ows--1046.org.readthedocs.build/en/1046/

@pjonsson
Copy link
Contributor Author

pjonsson commented Aug 6, 2024

I'll debug+fix this after #1047 is merged.

@pjonsson pjonsson marked this pull request as draft August 6, 2024 13:59
@pjonsson pjonsson force-pushed the dockerfile-gdal-update branch 2 times, most recently from d13d098 to 95539f0 Compare August 6, 2024 22:23
Copy link

codecov bot commented Aug 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.63%. Comparing base (6cd0687) to head (f07fece).
Report is 1 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1046   +/-   ##
=======================================
  Coverage   93.63%   93.63%           
=======================================
  Files          43       43           
  Lines        6509     6509           
=======================================
  Hits         6095     6095           
  Misses        414      414           

@pjonsson pjonsson force-pushed the dockerfile-gdal-update branch 9 times, most recently from cf2a007 to 7cd7f28 Compare August 7, 2024 12:35
@pjonsson pjonsson marked this pull request as ready for review August 7, 2024 12:46
Make the minimal change to mirror
the change from datacube-explorer's
update to GDAL 3.9.
@@ -25,18 +23,18 @@ WORKDIR /code
COPY . /code

RUN echo "version=\"$(python3 setup.py --version)\"" > datacube_ows/_version.py \
&& pip install --no-cache-dir .[ops,test]
&& pip --disable-pip-version-check install --no-cache-dir .[ops,test] --break-system-packages
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason we need to pip --disable-pip-version-check all the time?

Can't we just && pip install --upgrade pip --break-system-packages && once up front?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The version check connects to some internet site, so not doing that check speeds up running pip.

From a security perspective, things like pip make it easier to get other software into a compromised container, so pip should be uninstalled at the end. And not upgrading pip ensures the uninstall will get everything and not leave some stray parts from one version.

@SpacemanPaul SpacemanPaul merged commit 2763129 into opendatacube:master Aug 8, 2024
14 checks passed
@pjonsson pjonsson deleted the dockerfile-gdal-update branch August 8, 2024 22:02
@pjonsson pjonsson mentioned this pull request Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants