-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dockerfile: update to GDAL 3.9.1 #1046
Dockerfile: update to GDAL 3.9.1 #1046
Conversation
I'll debug+fix this after #1047 is merged. |
d13d098
to
95539f0
Compare
cf2a007
to
7cd7f28
Compare
Make the minimal change to mirror the change from datacube-explorer's update to GDAL 3.9.
7cd7f28
to
f07fece
Compare
@@ -25,18 +23,18 @@ WORKDIR /code | |||
COPY . /code | |||
|
|||
RUN echo "version=\"$(python3 setup.py --version)\"" > datacube_ows/_version.py \ | |||
&& pip install --no-cache-dir .[ops,test] | |||
&& pip --disable-pip-version-check install --no-cache-dir .[ops,test] --break-system-packages |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reason we need to pip --disable-pip-version-check
all the time?
Can't we just && pip install --upgrade pip --break-system-packages &&
once up front?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The version check connects to some internet site, so not doing that check speeds up running pip.
From a security perspective, things like pip make it easier to get other software into a compromised container, so pip should be uninstalled at the end. And not upgrading pip ensures the uninstall will get everything and not leave some stray parts from one version.
Make the minimal change to mirror
the change from datacube-explorer's
update to GDAL 3.9.
📚 Documentation preview 📚: https://datacube-ows--1046.org.readthedocs.build/en/1046/